DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

fix breaking change in setMeasureFunc after emscripten migration #1219

Closed
jeetiss wants to merge 5 commits from fix-major-change into main
pull from: fix-major-change
merge into: DaddyFrosty:main
Conversation 2 Commits 5 Files Changed 2 +55 -12
jeetiss commented 2023-01-26 06:35:42 -08:00 (Migrated from github.com)
Copy Link

current MeasureFunc is stricter than the previous one and when it returns only one dimension object yoga throw TypeError: Missing field: "height" or TypeError: Missing field: "width"

this is a breaking change and @react-pdf use this feature a lot, so i wanna return the previous behavior back

codesandbox with reproduction on yoga-layout-prebuilt: https://codesandbox.io/s/yoga-layout-measure-callback-wrong-data-1l9133

current `MeasureFunc` is stricter than the previous one and when it returns only one dimension object yoga throw `TypeError: Missing field: "height"` or `TypeError: Missing field: "width"` this is a breaking change and `@react-pdf` use this feature a lot, so i wanna return the previous behavior back codesandbox with reproduction on `yoga-layout-prebuilt`: https://codesandbox.io/s/yoga-layout-measure-callback-wrong-data-1l9133
facebook-github-bot commented 2023-01-26 09:08:29 -08:00 (Migrated from github.com)
Copy Link

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D42778696).
facebook-github-bot commented 2023-01-26 16:24:35 -08:00 (Migrated from github.com)
Copy Link

@jacdebug merged this pull request in facebook/yoga@5496554cbf.

@jacdebug merged this pull request in facebook/yoga@5496554cbf450633066b7bfad6839dd9524018fe.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1219
No description provided.
Delete Branch "fix-major-change"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?