DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

es6 compatable enums #1229

Closed
jeetiss wants to merge 2 commits from es6-enums into main
pull from: es6-enums
merge into: DaddyFrosty:main
Conversation 3 Commits 2 Files Changed 3 +69 -72
jeetiss commented 2023-02-20 01:31:44 -08:00 (Migrated from github.com)
Copy Link

I wanna repeat the constants export in yoga-wasm-web, to achieve

import { ALIGN_CENTER } from "yoga-layout";

And I failed. it is impossible because rollup and other tools can't transform commonjs module.exports = { WHATEVER: 1 } into ECMAScript modules. however, they can work with separate exports like exports.WHATEVER = 1 and this PR transforms yoga constants into this convertible format

This doesn't change anything for the yoga package, but it makes it possible to reexport constants without any modification and hacks, like this

export * from "./javascript/src_js/generated/YGEnums.js";

discussion in yoga-layout-wasm

I wanna repeat the constants export in `yoga-wasm-web`, to achieve ```js import { ALIGN_CENTER } from "yoga-layout"; ``` And I failed. it is impossible because `rollup` and other tools can't transform commonjs `module.exports = { WHATEVER: 1 }` into ECMAScript modules. however, they can work with separate exports like `exports.WHATEVER = 1` and this PR transforms yoga constants into this convertible format This doesn't change anything for the yoga package, but it makes it possible to reexport constants without any modification and hacks, like this ```js export * from "./javascript/src_js/generated/YGEnums.js"; ``` [discussion in yoga-layout-wasm](https://github.com/shuding/yoga-wasm-web/pull/15)
👍 1
facebook-github-bot commented 2023-02-20 05:23:16 -08:00 (Migrated from github.com)
Copy Link

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@rshest has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D43437177).
rshest (Migrated from github.com) approved these changes 2023-02-20 05:23:56 -08:00
facebook-github-bot commented 2023-02-20 19:57:29 -08:00 (Migrated from github.com)
Copy Link

@rshest merged this pull request in facebook/yoga@13eacf8858.

@rshest merged this pull request in facebook/yoga@13eacf88588694eca86647a8e55389f416396d89.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
rshest
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1229
No description provided.
Delete Branch "es6-enums"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?