DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

fix: types tweaks #1236

Closed
jeetiss wants to merge 2 commits from types-tweaks into main
pull from: types-tweaks
merge into: DaddyFrosty:main
Conversation 3 Commits 2 Files Changed 3 +114 -118
jeetiss commented 2023-03-12 03:31:12 -07:00 (Migrated from github.com)
Copy Link
- format types with `prettier` - apply suggestion from https://github.com/facebook/yoga/pull/1233#discussion_r1120807560
NickGerleman (Migrated from github.com) approved these changes 2023-03-14 01:36:26 -07:00
javascript/src_js/index.d.ts
@@ -9,3 +9,3 @@
import type {Yoga} from './wrapAsm';
import type { Yoga } from "./wrapAsm";
NickGerleman (Migrated from github.com) commented 2023-03-14 01:28:11 -07:00
Copy Link

I forgot that I had told ESLint to ignore .d.ts files. c09405d58c/javascript/.eslintrc.js (L12)

I did that at the time because I didn't want to spend the time then to set up typescript-eslint a TS dep, and tests against the types. But it would be great to fix that up eventually.

I forgot that I had told ESLint to ignore `.d.ts` files. https://github.com/facebook/yoga/blob/c09405d58c624fd26d5e0a7ed98bd10c5cc4c05b/javascript/.eslintrc.js#L12 I did that at the time because I didn't want to spend the time then to set up `typescript-eslint` a TS dep, and tests against the types. But it would be great to fix that up eventually.
facebook-github-bot commented 2023-03-14 01:39:10 -07:00 (Migrated from github.com)
Copy Link

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D44052580).
facebook-github-bot commented 2023-03-14 04:19:00 -07:00 (Migrated from github.com)
Copy Link

@NickGerleman merged this pull request in facebook/yoga@b17f08ed49.

@NickGerleman merged this pull request in facebook/yoga@b17f08ed4915f24b794a7f2ffdc5cd0acfaf88e1.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
NickGerleman
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1236
No description provided.
Delete Branch "types-tweaks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?