DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Minor formatting: added space in YGNodeMarkDirty assert message #1243

Closed
inobelar wants to merge 1 commits from patch-2 into main
pull from: patch-2
merge into: DaddyFrosty:main
Conversation 2 Commits 1 Files Changed 1 +1 -1
inobelar commented 2023-04-11 01:29:41 -07:00 (Migrated from github.com)
Copy Link

Currently YGNodeMarkDirty() assert message displayed without space between 2 lines:

"Only leaf nodes with custom measure functionsshould manually mark themselves as dirty"
                                     ^^^^^^^^^^^^^^^

This minor PR fixes it :)

Currently `YGNodeMarkDirty()` assert message displayed **without** space between 2 lines: ``` "Only leaf nodes with custom measure functionsshould manually mark themselves as dirty" ^^^^^^^^^^^^^^^ ``` This minor PR fixes it :)
facebook-github-bot commented 2023-04-11 06:14:41 -07:00 (Migrated from github.com)
Copy Link

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@javache has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D44870410).
facebook-github-bot commented 2023-04-11 08:46:41 -07:00 (Migrated from github.com)
Copy Link

@javache merged this pull request in facebook/yoga@d06f7b989e.

@javache merged this pull request in facebook/yoga@d06f7b989e02a61d02aa6456b0b61f65b13961d0.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1243
No description provided.
Delete Branch "patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?