DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Move YogaKit to YGErrataClassic #1261

Closed
NickGerleman wants to merge 2 commits from export-D45298803 into main
pull from: export-D45298803
merge into: DaddyFrosty:main
Conversation 9 Commits 2 Files Changed 2 +7
NickGerleman commented 2023-04-25 17:44:22 -07:00 (Migrated from github.com)
Copy Link

Summary:
YogaKit integrates Yoga with UIKit as a higher level framework. It does not expose config setting to users.

We set YGErrataClassic for now to prioritize compatibility instead of conformance (YogaKit is relatively used in fbsource as well).

I'm also tempted to remove the usage of ExperimentalWebFlexBasis since last I heard rozelle thought it was generally broken, but I am a bit afraid to if it has been enabled so long, and is used in many cases in Meta.

Differential Revision: D45298803

Summary: YogaKit integrates Yoga with UIKit as a higher level framework. It does not expose config setting to users. We set YGErrataClassic for now to prioritize compatibility instead of conformance (YogaKit is relatively used in fbsource as well). I'm also tempted to remove the usage of ExperimentalWebFlexBasis since last I heard rozelle thought it was generally broken, but I am a bit afraid to if it has been enabled so long, and is used in many cases in Meta. Differential Revision: D45298803
facebook-github-bot commented 2023-04-25 17:45:11 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45298803

This pull request was **exported** from Phabricator. Differential Revision: [D45298803](https://www.internalfb.com/diff/D45298803)
facebook-github-bot commented 2023-04-26 21:51:38 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45298803

This pull request was **exported** from Phabricator. Differential Revision: [D45298803](https://www.internalfb.com/diff/D45298803)
facebook-github-bot commented 2023-04-26 21:57:24 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45298803

This pull request was **exported** from Phabricator. Differential Revision: [D45298803](https://www.internalfb.com/diff/D45298803)
facebook-github-bot commented 2023-04-27 06:31:41 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45298803

This pull request was **exported** from Phabricator. Differential Revision: [D45298803](https://www.internalfb.com/diff/D45298803)
facebook-github-bot commented 2023-04-27 06:58:18 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45298803

This pull request was **exported** from Phabricator. Differential Revision: [D45298803](https://www.internalfb.com/diff/D45298803)
facebook-github-bot commented 2023-04-27 07:05:29 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45298803

This pull request was **exported** from Phabricator. Differential Revision: [D45298803](https://www.internalfb.com/diff/D45298803)
facebook-github-bot commented 2023-04-27 09:43:03 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45298803

This pull request was **exported** from Phabricator. Differential Revision: [D45298803](https://www.internalfb.com/diff/D45298803)
facebook-github-bot commented 2023-04-27 10:20:13 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45298803

This pull request was **exported** from Phabricator. Differential Revision: [D45298803](https://www.internalfb.com/diff/D45298803)
facebook-github-bot commented 2023-04-27 13:56:57 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@c1a5219b03.

This pull request has been merged in facebook/yoga@c1a5219b03be6ece37bff2d699e248c96367389a.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1261
No description provided.
Delete Branch "export-D45298803"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?