DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Lint and typecheck TypeScript #1276

Closed
NickGerleman wants to merge 2 commits from export-D45508576 into main
pull from: export-D45508576
merge into: DaddyFrosty:main
Conversation 3 Commits 2 Files Changed 7 +372 -17
NickGerleman commented 2023-05-02 16:39:46 -07:00 (Migrated from github.com)
Copy Link

Summary:
This change starts to enlighten linting and other repo configuration to TypeScript. This was previously special-cased out of linting, and meant we were not linting everything. It is also a precondition to do real typechecking and linting our definitions with type information.

  1. Add TypeScript dependencies
  2. Configure ESLint, Babel, tsc for TypeScript
  3. Run tsc as part of linting (OSS only for now)

This is continued in another change with adding types to scripts and config files, but more importantly converting hand-written tests and test generation to TypeScript, so we get real-world usage to typecheck against for testing.

Differential Revision: D45508576

Summary: This change starts to enlighten linting and other repo configuration to TypeScript. This was previously special-cased out of linting, and meant we were not linting everything. It is also a precondition to do real typechecking and linting our definitions with type information. 1. Add TypeScript dependencies 1. Configure ESLint, Babel, tsc for TypeScript 1. Run tsc as part of linting (OSS only for now) This is continued in another change with adding types to scripts and config files, but more importantly converting hand-written tests and test generation to TypeScript, so we get real-world usage to typecheck against for testing. Differential Revision: D45508576
facebook-github-bot commented 2023-05-02 16:40:18 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45508576

This pull request was **exported** from Phabricator. Differential Revision: [D45508576](https://www.internalfb.com/diff/D45508576)
facebook-github-bot commented 2023-05-02 16:45:16 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45508576

This pull request was **exported** from Phabricator. Differential Revision: [D45508576](https://www.internalfb.com/diff/D45508576)
facebook-github-bot commented 2023-05-04 08:15:41 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@19aed1d63e.

This pull request has been merged in facebook/yoga@19aed1d63e8ccbef462c2e65f023f6acc77dde57.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1276
No description provided.
Delete Branch "export-D45508576"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?