DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

AGP to 8.0.1 #1280

Closed
cortinico wants to merge 3 commits from export-D45564575 into main
pull from: export-D45564575
merge into: DaddyFrosty:main
Conversation 2 Commits 3 Files Changed 8 +27 -16
cortinico commented 2023-05-04 05:26:47 -07:00 (Migrated from github.com)
Copy Link

Summary:
I'm refreshing some of the dependencies of the project,
here doing AGP to 8.0.1.
I'm also removing the older publishing plugin as we're most likely going to use
Gradle's default publishing + another plugin to manage the nexus interactions (the same we use on React Native).

I'm also doing some changes on the JDK side:

  • Bumps the JDK version to 17 as that's required by AGP
  • Bumps the source/target version to JDK 8. JDK 7 is long deprecated and we're getting a lot of warnings for it on console. Users should be on JDK 11 already by now, but 8 is also good enough.

Differential Revision: D45564575

Summary: I'm refreshing some of the dependencies of the project, here doing AGP to 8.0.1. I'm also removing the older publishing plugin as we're most likely going to use Gradle's default publishing + another plugin to manage the nexus interactions (the same we use on React Native). I'm also doing some changes on the JDK side: - Bumps the JDK version to 17 as that's required by AGP - Bumps the source/target version to JDK 8. JDK 7 is long deprecated and we're getting a lot of warnings for it on console. Users should be on JDK 11 already by now, but 8 is also good enough. Differential Revision: D45564575
facebook-github-bot commented 2023-05-04 05:27:34 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45564575

This pull request was **exported** from Phabricator. Differential Revision: [D45564575](https://www.internalfb.com/diff/D45564575)
facebook-github-bot commented 2023-05-05 04:12:09 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@54d78926ce.

This pull request has been merged in facebook/yoga@54d78926ce452bd8f0f83eeb9008c407c8227e78.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1280
No description provided.
Delete Branch "export-D45564575"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?