DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fixup TypeScript with export maps #1284

Closed
NickGerleman wants to merge 2 commits from export-D45713689 into main
pull from: export-D45713689
merge into: DaddyFrosty:main
Conversation 5 Commits 2 Files Changed 29 +447 -723
NickGerleman commented 2023-05-09 21:09:01 -07:00 (Migrated from github.com)
Copy Link

Summary:
This makes TypeScript resolution play nicely with export maps, and converts the entrypoints to TypeScript.

We remove the non-export-map fallbacks as well, so the export maps are always followed.

Tests are moved to load yoga from its external export, testing the entrypoints.

This moves the only untyped bit to the binary wrapper, which another diff will move.

Reviewed By: yungsters

Differential Revision: D45713689

Summary: This makes TypeScript resolution play nicely with export maps, and converts the entrypoints to TypeScript. We remove the non-export-map fallbacks as well, so the export maps are always followed. Tests are moved to load yoga from its external export, testing the entrypoints. This moves the only untyped bit to the binary wrapper, which another diff will move. Reviewed By: yungsters Differential Revision: D45713689
facebook-github-bot commented 2023-05-09 21:10:01 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45713689

This pull request was **exported** from Phabricator. Differential Revision: [D45713689](https://www.internalfb.com/diff/D45713689)
facebook-github-bot commented 2023-05-09 21:24:05 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45713689

This pull request was **exported** from Phabricator. Differential Revision: [D45713689](https://www.internalfb.com/diff/D45713689)
facebook-github-bot commented 2023-05-09 21:29:53 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45713689

This pull request was **exported** from Phabricator. Differential Revision: [D45713689](https://www.internalfb.com/diff/D45713689)
facebook-github-bot commented 2023-05-09 21:37:46 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45713689

This pull request was **exported** from Phabricator. Differential Revision: [D45713689](https://www.internalfb.com/diff/D45713689)
facebook-github-bot commented 2023-05-09 22:24:41 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@af89315fd4.

This pull request has been merged in facebook/yoga@af89315fd45eafdfe00d691adbec70b2c30446e6.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1284
No description provided.
Delete Branch "export-D45713689"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?