DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Move generated Jest tests to TypeScript #1287

Closed
NickGerleman wants to merge 2 commits from export-D45723545 into main
pull from: export-D45723545
merge into: DaddyFrosty:main
Conversation 4 Commits 2 Files Changed 55 +3533 -2435
NickGerleman commented 2023-05-10 00:27:22 -07:00 (Migrated from github.com)
Copy Link

Summary:
Outputs tests as TypeScript, along with using/testing the new form of enums imported directly from the package.

We need to change how we are telling Jest which variant to run, so that tests can import enums from "yoga-layout" and have it resolve to the entrypoint which has a binary which has already been built.

Differential Revision: D45723545

Summary: Outputs tests as TypeScript, along with using/testing the new form of enums imported directly from the package. We need to change how we are telling Jest which variant to run, so that tests can import enums from "yoga-layout" and have it resolve to the entrypoint which has a binary which has already been built. Differential Revision: D45723545
facebook-github-bot commented 2023-05-10 00:28:17 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45723545

This pull request was **exported** from Phabricator. Differential Revision: [D45723545](https://www.internalfb.com/diff/D45723545)
facebook-github-bot commented 2023-05-10 21:00:58 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45723545

This pull request was **exported** from Phabricator. Differential Revision: [D45723545](https://www.internalfb.com/diff/D45723545)
facebook-github-bot commented 2023-05-10 21:12:31 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45723545

This pull request was **exported** from Phabricator. Differential Revision: [D45723545](https://www.internalfb.com/diff/D45723545)
facebook-github-bot commented 2023-05-10 22:51:04 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@149849d22b.

This pull request has been merged in facebook/yoga@149849d22bf34d38606cbadaef3e328a4c5047f3.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1287
No description provided.
Delete Branch "export-D45723545"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?