DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Change how we set cmake policy #1288

Closed
NickGerleman wants to merge 1 commits from export-D45724864 into main
pull from: export-D45724864
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 6 +6 -7
NickGerleman commented 2023-05-10 01:12:50 -07:00 (Migrated from github.com)
Copy Link

Summary:
Fixes https://github.com/facebook/yoga/issues/1283

New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in cmake_minimum_required.

Setting a policy to true (to opt into new behavior where cmake_minimum_required is lower than the current version) seems actually just error out on the old versions.

Googling around, apparently the way I should be doing this is to specify <policy_max> as part of cmake_minimum_required . https://gitlab.kitware.com/cmake/cmake/-/issues/20392

This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum.

Differential Revision: D45724864

Summary: Fixes https://github.com/facebook/yoga/issues/1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Differential Revision: D45724864
facebook-github-bot commented 2023-05-10 01:13:53 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45724864

This pull request was **exported** from Phabricator. Differential Revision: [D45724864](https://www.internalfb.com/diff/D45724864)
facebook-github-bot commented 2023-05-15 13:51:39 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45724864

This pull request was **exported** from Phabricator. Differential Revision: [D45724864](https://www.internalfb.com/diff/D45724864)
facebook-github-bot commented 2023-05-15 14:48:20 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D45724864

This pull request was **exported** from Phabricator. Differential Revision: [D45724864](https://www.internalfb.com/diff/D45724864)
facebook-github-bot commented 2023-05-15 15:25:52 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@f2b4e42ca2.

This pull request has been merged in facebook/yoga@f2b4e42ca28e8df2384305225c2cf7935ac79d28.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1288
No description provided.
Delete Branch "export-D45724864"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?