DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Update tests to expect align-items: stretch as default instead of flex-start #13

Closed
astreet wants to merge 1 commits from default_stretch into master
pull from: default_stretch
merge into: DaddyFrosty:master
Conversation 3 Commits 1 Files Changed 5 +23 -23
astreet commented 2014-10-07 22:34:25 -07:00 (Migrated from github.com)
Copy Link

I'm submitting this for review: it does not update the JS tests so it probably shouldn't go in. I just updated the tests that were failing when I changed the defaults based on reading http://css-tricks.com/snippets/css/a-guide-to-flexbox/ for expected behavior. I'm pretty sure I got the expected behavior right but I want to make sure we're not reducing test coverage by making these changes. I'm not sure how you all decided what tests to put in in the first place so I'd like to get your thoughts.

Re: JS tests, I'm really not sure what's going on there. Making this change causes 50 tests to fail:
screen shot 2014-10-07 at 5 11 34 pm

I'm submitting this for review: it does not update the JS tests so it probably shouldn't go in. I just updated the tests that were failing when I changed the defaults based on reading http://css-tricks.com/snippets/css/a-guide-to-flexbox/ for expected behavior. I'm pretty sure I got the expected behavior right but I want to make sure we're not reducing test coverage by making these changes. I'm not sure how you all decided what tests to put in in the first place so I'd like to get your thoughts. Re: JS tests, I'm really not sure what's going on there. Making this change causes 50 tests to fail: ![screen shot 2014-10-07 at 5 11 34 pm](https://cloud.githubusercontent.com/assets/594924/4554358/d5a38d5e-4eac-11e4-96ae-8275b03f472f.png)
sophiebits commented 2014-10-07 22:54:53 -07:00 (Migrated from github.com)
Copy Link

The README says specifically that align-items: flex-start; was chosen to be the default here…

The README says specifically that `align-items: flex-start;` was chosen to be the default here…
astreet commented 2014-10-07 23:20:49 -07:00 (Migrated from github.com)
Copy Link

Ah, that should be updated then. I chatted with Christopher and apparently there have been issues that have made them change their minds. Christopher, want to chime in?

Ah, that should be updated then. I chatted with Christopher and apparently there have been issues that have made them change their minds. Christopher, want to chime in?
astreet commented 2014-10-08 09:56:17 -07:00 (Migrated from github.com)
Copy Link

Handled in #14

Handled in #14

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#13
No description provided.
Delete Branch "default_stretch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?