Remove In-tree C# Bindings #1302

2023-06-04T01:09:03-07:00

NickGerleman commented

2023-06-04 01:09:03 -07:00

(Migrated from github.com)

Summary:
These C# bindings were contributed as part of ff8f17ac99. They have occasionally been refreshed, but has never really had validation it built continuously, or dedicated maintenance.

There has been a surge of work with https://github.com/facebook/yoga/pull/1207 to try to modernize the build for these, but checking with jkoritzinsky I'm not sure either of us have the time to commit to supporting these at the same level as other bindings.

Some well-known projects like Unity had already abandoned this set of bindings for their own. 016297e35c (diff-c85198aaac9095a5446ed00b0fba8025072d235b2b69dea8aad85abc64a83e1e)

So, as part of the work for an official OSS release, and really trying to define what is deprecated, and what we will try to support, I am removing the in-tree C# bindings from Yoga.

In the past, gaps in Yoga bindings we haven't supported have led to new bindings with dedicated maintainers e.g. FlexLayout, yoga-rs, yoga-wasm-web. My hope is that by removing the C# bindings that we are not supporting, we free up the opportunity for a new version to become the defacto.

Differential Revision: D46425886

Summary: These C# bindings were contributed as part of https://github.com/facebook/yoga/commit/ff8f17ac990a9d5b8c1b44dd3fd414b382855b0c. They have occasionally been refreshed, but has never really had validation it built continuously, or dedicated maintenance. There has been a surge of work with https://github.com/facebook/yoga/pull/1207 to try to modernize the build for these, but checking with jkoritzinsky I'm not sure either of us have the time to commit to supporting these at the same level as other bindings. Some well-known projects like Unity had already abandoned this set of bindings for their own. https://github.com/Unity-Technologies/UnityCsReference/commit/016297e35ce1bf35a2c411f87fe0d6362cad54c3#diff-c85198aaac9095a5446ed00b0fba8025072d235b2b69dea8aad85abc64a83e1e So, as part of the work for an official OSS release, and really trying to define what is deprecated, and what we will try to support, I am removing the in-tree C# bindings from Yoga. In the past, gaps in Yoga bindings we haven't supported have led to new bindings with dedicated maintainers e.g. [FlexLayout](https://github.com/layoutBox/FlexLayout), [yoga-rs](https://github.com/bschwind/yoga-rs), [yoga-wasm-web](https://github.com/shuding/yoga-wasm-web). My hope is that by removing the C# bindings that we are not supporting, we free up the opportunity for a new version to become the defacto. Differential Revision: D46425886

facebook-github-bot commented

2023-06-04 01:10:06 -07:00

(Migrated from github.com)

This pull request was exported from Phabricator. Differential Revision: D46425886

This pull request was **exported** from Phabricator. Differential Revision: [D46425886](https://www.internalfb.com/diff/D46425886)

facebook-github-bot commented

2023-06-05 10:54:29 -07:00

(Migrated from github.com)

This pull request has been merged in facebook/yoga@5e74e20a4d.

This pull request has been merged in facebook/yoga@5e74e20a4df186827dce57ec663063be9898a0fb.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1302