DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Mark YogaKit Podspec as Deprecated #1306

Closed
NickGerleman wants to merge 1 commits from export-D46663201 into main
pull from: export-D46663201
merge into: DaddyFrosty:main
Conversation 9 Commits 1 Files Changed 1 +1
NickGerleman commented 2023-06-12 15:00:52 -07:00 (Migrated from github.com)
Copy Link

Summary:
We are deprecating YogaKit as part of Yoga 2.0, with that version planned as the last release. Mark the podspec as deprecated.

We are also deprecating the Android ViewGroup in a similar way but from the googling I did there is not an equivalent way to do that for Maven artifacts.

Differential Revision: D46663201

Summary: We are deprecating YogaKit as part of Yoga 2.0, with that version planned as the last release. Mark the podspec as deprecated. We are also deprecating the Android ViewGroup in a similar way but from the googling I did there is not an equivalent way to do that for Maven artifacts. Differential Revision: D46663201
facebook-github-bot commented 2023-06-12 15:01:54 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D46663201

This pull request was **exported** from Phabricator. Differential Revision: [D46663201](https://www.internalfb.com/diff/D46663201)
facebook-github-bot commented 2023-06-13 09:51:13 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D46663201

This pull request was **exported** from Phabricator. Differential Revision: [D46663201](https://www.internalfb.com/diff/D46663201)
facebook-github-bot commented 2023-06-13 09:57:40 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D46663201

This pull request was **exported** from Phabricator. Differential Revision: [D46663201](https://www.internalfb.com/diff/D46663201)
facebook-github-bot commented 2023-06-13 10:05:21 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D46663201

This pull request was **exported** from Phabricator. Differential Revision: [D46663201](https://www.internalfb.com/diff/D46663201)
facebook-github-bot commented 2023-06-13 10:17:34 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D46663201

This pull request was **exported** from Phabricator. Differential Revision: [D46663201](https://www.internalfb.com/diff/D46663201)
facebook-github-bot commented 2023-06-13 10:41:48 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D46663201

This pull request was **exported** from Phabricator. Differential Revision: [D46663201](https://www.internalfb.com/diff/D46663201)
facebook-github-bot commented 2023-06-13 11:41:49 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@2d408acbab.

This pull request has been merged in facebook/yoga@2d408acbabb3cd858f50cbc92ff175b28d198f2b.
rtPag commented 2023-06-16 00:05:09 -07:00 (Migrated from github.com)
Copy Link

Can you already share what the replacement for YogaKit will be?

Can you already share what the replacement for YogaKit will be?
NickGerleman commented 2023-06-16 13:14:45 -07:00 (Migrated from github.com)
Copy Link

Can you already share what the replacement for YogaKit will be?

We aren't currently planning a direct replacement. New experiences at Meta tend to be built with higher level frameworks over UIKit, like ComponentKit, or React Native.

Because we aren't spending the time to develop it further, the plan is to release YogaKit in its current state alongside the new Yoga bits in the 2.0 release we are doing later this month, but mark it deprecated. The last source revision will be present in 2.0 branch we will make, but we will remove it from the main branch after.

The revision in the branch should facilitate anyone who wants to fork the project, and I think there have been projects where folks have forked to add things like AppKit support. Once out of the Yoga repo, I hope we can encourage future development in one of those, instead of squatting on it to not do anything with it.

> Can you already share what the replacement for YogaKit will be? We aren't currently planning a direct replacement. New experiences at Meta tend to be built with higher level frameworks over UIKit, like ComponentKit, or React Native. Because we aren't spending the time to develop it further, the plan is to release YogaKit in its current state alongside the new Yoga bits in the 2.0 release we are doing later this month, but mark it deprecated. The last source revision will be present in 2.0 branch we will make, but we will remove it from the main branch after. The revision in the branch should facilitate anyone who wants to fork the project, and I think there have been projects where folks have forked to add things like AppKit support. Once out of the Yoga repo, I hope we can encourage future development in one of those, instead of squatting on it to not do anything with it.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1306
No description provided.
Delete Branch "export-D46663201"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?