DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix width being ignored when has a value of 0 #134

Merged
vjeux merged 1 commits from fix_dim_0 into master 2015-09-25 14:43:52 -07:00
Conversation 5 Commits 1 Files Changed 14 +140 -23
vjeux commented 2015-09-25 13:15:33 -07:00 (Migrated from github.com)
Copy Link

8f6a96adbc added a test in isDimDefined that checks if value > 0.0, but unfortunately, it did not faithfully port the JavaScript version which is value >= 0.0: https://github.com/facebook/css-layout/blob/master/src/Layout.js#L306. Sadly, no test covered this so it went unnoticed.

https://github.com/facebook/css-layout/commit/8f6a96adbcb2b0389f948b8113d8b7cb8991bb2d added a test in isDimDefined that checks if `value > 0.0`, but unfortunately, it did not faithfully port the JavaScript version which is `value >= 0.0`: https://github.com/facebook/css-layout/blob/master/src/Layout.js#L306. Sadly, no test covered this so it went unnoticed.
vjeux commented 2015-09-25 14:25:54 -07:00 (Migrated from github.com)
Copy Link

@facebook-github-bot import

@facebook-github-bot import
facebook-github-bot commented 2015-09-25 14:28:57 -07:00 (Migrated from github.com)
Copy Link

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/626460604160444/int_phab to review.

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/626460604160444/int_phab to review.
lucasr commented 2015-09-25 14:41:18 -07:00 (Migrated from github.com)
Copy Link

Looks good to me.

Looks good to me.
vjeux commented 2015-09-25 14:43:57 -07:00 (Migrated from github.com)
Copy Link

@facebook-github-bot shipit

@facebook-github-bot shipit
facebook-github-bot commented 2015-09-25 14:44:34 -07:00 (Migrated from github.com)
Copy Link

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/626460604160444/int_phab to review.

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/626460604160444/int_phab to review.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#134
No description provided.
Delete Branch "fix_dim_0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?