Add reset() method to CSSNode #140

Merged

lucasr merged 1 commits from fast-reset into master 2015-10-08 07:06:49 -07:00

Conversation 6 Commits 1 Files Changed 3 +219 -170

lucasr commented 2015-10-05 08:59:25 -07:00 (Migrated from github.com)

Copy Link

This allows users of css-layout in Java to perform faster resets on
CSSNode in cases when you want to recycle instances.

CSSLayout.resetResult() was renamed to simply reset() for consistency.

This allows users of css-layout in Java to perform faster resets on CSSNode in cases when you want to recycle instances. CSSLayout.resetResult() was renamed to simply reset() for consistency.

lucasr commented 2015-10-08 05:16:49 -07:00 (Migrated from github.com)

Copy Link

@kmagiera @foghina ping?

@kmagiera @foghina ping?

foghina commented 2015-10-08 05:29:06 -07:00 (Migrated from github.com)

Copy Link

See my inlines, otherwise

Not a big fan of the breaking API change, but as long as you fix usages, I'll allow it.

See my inlines, otherwise  Not a big fan of the breaking API change, but as long as you fix usages, I'll allow it.

lucasr commented 2015-10-08 06:19:58 -07:00 (Migrated from github.com)

Copy Link

@foghina What API break?

@foghina What API break?

foghina commented 2015-10-08 06:33:48 -07:00 (Migrated from github.com)

Copy Link

What API break?

resetResult() -> reset().

> What API break? `resetResult()` -> `reset()`.

lucasr commented 2015-10-08 06:44:42 -07:00 (Migrated from github.com)

Copy Link

@foghina Ah, I thought CSSLayout was package-private. Reverted this change to avoid the API break.

@foghina Ah, I thought CSSLayout was package-private. Reverted this change to avoid the API break.

lucasr commented 2015-10-08 06:51:28 -07:00 (Migrated from github.com)

Copy Link

Updated the branch:

• Reverted resetLayout() rename to avoid API break
• Don't reset measure function on reset to avoid problems in RN
• Attachment check before resetting in CSSNode as suggested

Updated the branch: - Reverted resetLayout() rename to avoid API break - Don't reset measure function on reset to avoid problems in RN - Attachment check before resetting in CSSNode as suggested

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Algorithm

Build and Infrastructure

C#

C++ Enhancement

CLA Signed

Discussion

Documentation

Feature Request

Java

JavaScript

Merged

Question

Reverted

Shared with Meta

Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

YogaKit

YogaLayout ViewGroup

bug

dependencies

Pull requests that update a dependency file

duplicate

enhancement

fb-exported

fh:direct-merge-enabled

invalid

ruby

Pull requests that update Ruby code

wontfix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

DaddyFrosty

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#140

No description provided.