DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

WIP: FloatOptional GCC build fix and more constexpr #1411

Closed
NickGerleman wants to merge 22 commits from NickGerleman-fix-gcc-floatoptional into main
pull from: NickGerleman-fix-gcc-floatoptional
merge into: DaddyFrosty:main
Conversation 3 Commits 22 Files Changed 4 +40 -44
NickGerleman commented 2023-10-03 16:22:57 -07:00 (Migrated from github.com)
Copy Link

GCC flags that is is not declared constexpr but that unwrapOrDefault() is. std::isnan is not constexpr until C++ 23 (because we cannot have nice things), so I made yoga::isUndefined() constexpr, using the same code std::isnan() boils down to. I then made FloatOptional depend on Comparison.h (instead of the other way around), so we can use it.

GCC flags that is is not declared `constexpr` but that `unwrapOrDefault()` is. `std::isnan` is not constexpr until C++ 23 (because we cannot have nice things), so I made `yoga::isUndefined()` constexpr, using the same code `std::isnan()` boils down to. I then made `FloatOptional` depend on `Comparison.h` (instead of the other way around), so we can use it.
facebook-github-bot commented 2023-10-03 18:21:38 -07:00 (Migrated from github.com)
Copy Link

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D49896837).
facebook-github-bot commented 2023-10-03 18:44:41 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D49896837

This pull request was **exported** from Phabricator. Differential Revision: [D49896837](https://www.internalfb.com/diff/D49896837)
facebook-github-bot commented 2023-10-04 02:02:30 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D49896837

This pull request was **exported** from Phabricator. Differential Revision: [D49896837](https://www.internalfb.com/diff/D49896837)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1411
No description provided.
Delete Branch "NickGerleman-fix-gcc-floatoptional"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?