DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

npm release #149

New Issue
Closed
opened 2015-11-08 21:19:43 -08:00 by devongovett · 5 comments
devongovett commented 2015-11-08 21:19:43 -08:00 (Migrated from github.com)
Copy Link

Last npm release was in September, but some changes have happened since then. Can someone release a new version to npm? Thanks!

Last npm release was in September, but some changes have happened since then. Can someone release a new version to npm? Thanks!
vjeux commented 2015-11-09 08:52:25 -08:00 (Migrated from github.com)
Copy Link

cc @ColinEberhardt

cc @ColinEberhardt
ColinEberhardt commented 2015-11-09 09:21:23 -08:00 (Migrated from github.com)
Copy Link

Good call - yes, it's been a while. I'll take a look at this tonight or tomorrow morning :-)

Good call - yes, it's been a while. I'll take a look at this tonight or tomorrow morning :-)
ColinEberhardt commented 2015-11-10 23:31:04 -08:00 (Migrated from github.com)
Copy Link

Done:

https://github.com/facebook/css-layout/releases/tag/v1.1.0

You'll also find this release up on npm. Would be great to get #142 resolved so that the C# API is properly managed also.

Done: https://github.com/facebook/css-layout/releases/tag/v1.1.0 You'll also find this release up on npm. Would be great to get #142 resolved so that the C# API is properly managed also.
devongovett commented 2015-11-11 23:33:00 -08:00 (Migrated from github.com)
Copy Link

Looks like dist/css-layout.js didn't get rebuilt before the release. It still has the old code. IMHO this should probably be an npm prepublish script.

Looks like dist/css-layout.js didn't get rebuilt before the release. It still has the old code. IMHO this should probably be an npm prepublish script.
ColinEberhardt commented 2015-11-12 06:34:33 -08:00 (Migrated from github.com)
Copy Link

@devongovett thanks for the heads-up, I've published v1.1.1 that should fix this.

I clearly need to do a bit more work on the process, I'll update shortly!

@devongovett thanks for the heads-up, I've published v1.1.1 that should fix this. I clearly need to do a bit more work on the process, I'll update shortly!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#149
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?