DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Sign generated tests #1503

Closed
joevilches wants to merge 5 commits from export-D51966201 into main
pull from: export-D51966201
merge into: DaddyFrosty:main
Conversation 6 Commits 5 Files Changed 77 +519 -279
joevilches commented 2023-12-08 17:14:27 -08:00 (Migrated from github.com)
Copy Link

Summary: This diff makes it so that our driver will sign all of the generated files to help ensure that they are not edited by hand. Next I will add CI to actually verify the signature

Differential Revision: D51966201

Summary: This diff makes it so that our driver will sign all of the generated files to help ensure that they are not edited by hand. Next I will add CI to actually verify the signature Differential Revision: D51966201
facebook-github-bot commented 2023-12-08 17:15:11 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D51966201

This pull request was **exported** from Phabricator. Differential Revision: [D51966201](https://www.internalfb.com/diff/D51966201)
facebook-github-bot commented 2023-12-08 17:24:15 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D51966201

This pull request was **exported** from Phabricator. Differential Revision: [D51966201](https://www.internalfb.com/diff/D51966201)
nicoburns commented 2023-12-10 15:51:16 -08:00 (Migrated from github.com)
Copy Link

In Taffy we run the test generation in CI and then use git to check for changes files and fail the check if there are any. IMO this is a better approach than signing the tests, as it also catches the case where someone has edited a fixture and has forgotten to run the test generator at all (in which case the test signature would be valid but would no longer match the fixture)

In Taffy we run the test generation in CI and then use git to check for changes files and fail the check if there are any. IMO this is a better approach than signing the tests, as it also catches the case where someone has edited a fixture and has forgotten to run the test generator at all (in which case the test signature would be valid but would no longer match the fixture)
joevilches commented 2023-12-11 09:06:57 -08:00 (Migrated from github.com)
Copy Link

I am also implementing a check for that, just not published yet. The signing has some extra internal benefits including changing the cursor in VS code so it is obvious the code should not be edited by hand, and internal CI checks from for free if you have a signature

I am also implementing a check for that, just not published yet. The signing has some extra internal benefits including changing the cursor in VS code so it is obvious the code should not be edited by hand, and internal CI checks from for free if you have a signature
facebook-github-bot commented 2023-12-11 10:48:31 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D51966201

This pull request was **exported** from Phabricator. Differential Revision: [D51966201](https://www.internalfb.com/diff/D51966201)
facebook-github-bot commented 2023-12-14 11:53:53 -08:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@4743040d62.

This pull request has been merged in facebook/yoga@4743040d62d3eda87dbeab478866b6af223a9361.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1503
No description provided.
Delete Branch "export-D51966201"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?