DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Manage native build toolchain #1506

Closed
NickGerleman wants to merge 1 commits from export-D52013026 into main
pull from: export-D52013026
merge into: DaddyFrosty:main
Conversation 20 Commits 1 Files Changed 11 +145 -92
NickGerleman commented 2023-12-09 17:48:55 -08:00 (Migrated from github.com)
Copy Link

Summary:
In order to build the website, you must build a Yoga binary. This usually requires installing native toolchains.

We have warning messages for these right now, but an even better solution is to just manage the dependencies ourselves. This does that, bringing in specific CMake and Ninja binaries from NPM, and caching a local copy of Emscripten during the build.

This also delays acquiring Emscripten in CI builds until it is needed, and I added some caching for it as well. It guaranttes users always have Ninja for fast and reliable C++ builds.

Differential Revision: D52013026

Summary: In order to build the website, you must build a Yoga binary. This usually requires installing native toolchains. We have warning messages for these right now, but an even better solution is to just manage the dependencies ourselves. This does that, bringing in specific CMake and Ninja binaries from NPM, and caching a local copy of Emscripten during the build. This also delays acquiring Emscripten in CI builds until it is needed, and I added some caching for it as well. It guaranttes users always have Ninja for fast and reliable C++ builds. Differential Revision: D52013026
facebook-github-bot commented 2023-12-09 17:49:46 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 18:00:18 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 18:08:40 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 18:14:44 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 18:20:29 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 18:28:20 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 18:35:27 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 18:42:16 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 18:49:33 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 19:09:32 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 19:17:09 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 20:15:05 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 20:23:03 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 21:22:25 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-09 21:33:00 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-10 19:42:39 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-10 19:49:49 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-11 03:17:52 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-11 03:25:26 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D52013026

This pull request was **exported** from Phabricator. Differential Revision: [D52013026](https://www.internalfb.com/diff/D52013026)
facebook-github-bot commented 2023-12-12 09:13:06 -08:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@0d03d8a06d.

This pull request has been merged in facebook/yoga@0d03d8a06d9715f41504996c5336fdd27da8fba4.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1506
No description provided.
Delete Branch "export-D52013026"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?