DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Reduce warning level of distributed Yoga builds #1592

Closed
NickGerleman wants to merge 1 commits from export-D54735661 into main
pull from: export-D54735661
merge into: DaddyFrosty:main
Conversation 3 Commits 1 Files Changed 2 -4
NickGerleman commented 2024-03-10 22:00:19 -07:00 (Migrated from github.com)
Copy Link

Summary:
Yoga may be built with a high warning level. This is helpful in letting Yoga be used in more places, and finding defects. We currently set these in the internal BUCK build, the CMake reference build, and the Yoga Standalone (not RN) CocoaPods build.

Yoga's reference CMake build and spec are consumed today by users of Yoga, instead of just Yoga developers. Here, it makes more sense to avoid anything that could break compiler-to-compiler compatibility.

We default these to a less intense (-Wall -Werror). I kept /W4, for pragmatic reasons, and since it is relatively standard for MSVC.

We continue to build with strict flags on Buck build on Clang.

Fixes https://github.com/facebook/yoga/issues/1590

Differential Revision: D54735661

Summary: Yoga may be built with a high warning level. This is helpful in letting Yoga be used in more places, and finding defects. We currently set these in the internal BUCK build, the CMake reference build, and the Yoga Standalone (not RN) CocoaPods build. Yoga's reference CMake build and spec are consumed today by users of Yoga, instead of just Yoga developers. Here, it makes more sense to avoid anything that could break compiler-to-compiler compatibility. We default these to a less intense (`-Wall -Werror`). I kept `/W4`, for pragmatic reasons, and since it is relatively standard for MSVC. We continue to build with strict flags on Buck build on Clang. Fixes https://github.com/facebook/yoga/issues/1590 Differential Revision: D54735661
vercel[bot] commented 2024-03-10 22:00:23 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 5:03am
[vc]: #UYT1C6vem9IfUIe6LSLBXDhFnYV7cCu4nvWPaXXISJA=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUtbmV4dCIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlLW5leHQvM2lNWTNDdXVzSDNOalNRdFFLdldoUWtub0p1VSIsInByZXZpZXdVcmwiOiJ5b2dhLXdlYnNpdGUtbmV4dC1naXQtZm9yay1uaWNrZ2VybGVtYW4tZXhwLTVkNTJmNC1mYm9wZW5zb3VyY2UudmVyY2VsLmFwcCIsIm5leHRDb21taXRTdGF0dXMiOiJERVBMT1lFRCIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJ5b2dhLXdlYnNpdGUtbmV4dC1naXQtZm9yay1uaWNrZ2VybGVtYW4tZXhwLTVkNTJmNC1mYm9wZW5zb3VyY2UudmVyY2VsLmFwcCJ9LCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZS1uZXh0In1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website-next** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website-next/3iMY3CuusH3NjSQtQKvWhQknoJuU)) | [Visit Preview](https://vercel.live/open-feedback/yoga-website-next-git-fork-nickgerleman-exp-5d52f4-fbopensource.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-next-git-fork-nickgerleman-exp-5d52f4-fbopensource.vercel.app?via=pr-comment-feedback-link) | Mar 11, 2024 5:03am |
facebook-github-bot commented 2024-03-10 22:00:26 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D54735661

This pull request was **exported** from Phabricator. Differential Revision: [D54735661](https://www.internalfb.com/diff/D54735661)
facebook-github-bot commented 2024-03-11 10:43:12 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@0d23e07202.

This pull request has been merged in facebook/yoga@0d23e07202414d679b92045ccac8c6c98f6cab9e.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1592
No description provided.
Delete Branch "export-D54735661"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?