DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Check layout instead of style before setting height and width to whatever is set in layout #161

Merged
emilsjolander merged 1 commits from master into master 2016-01-07 04:17:49 -08:00
Conversation 7 Commits 1 Files Changed 15 +333 -78
emilsjolander commented 2016-01-05 11:45:09 -08:00 (Migrated from github.com)
Copy Link

isDimDefined checks is node.style[axis] is defined while in these places we do not care about node.style[axis] but node.layout[axis]. This caused parent height not to be correctly propagated to children.

`isDimDefined` checks is node.style[axis] is defined while in these places we do not care about `node.style[axis]` but `node.layout[axis]`. This caused parent height not to be correctly propagated to children.
vjeux commented 2016-01-05 11:51:00 -08:00 (Migrated from github.com)
Copy Link

Can you add a test case?

Can you add a test case?
emilsjolander commented 2016-01-05 11:51:54 -08:00 (Migrated from github.com)
Copy Link

@vjeux will do

@vjeux will do
lucasr commented 2016-01-06 03:45:54 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander Does this fix alone that bug with a specific height being passed to the measure function?

@emilsjolander Does this fix alone that bug with a specific height being passed to the measure function?
emilsjolander commented 2016-01-06 03:47:14 -08:00 (Migrated from github.com)
Copy Link

@lucasr no. that is more a limitation than a bug

@lucasr no. that is more a limitation than a bug
emilsjolander commented 2016-01-06 05:13:58 -08:00 (Migrated from github.com)
Copy Link

@vjeux updated to include test case. Also changed implementation to avoid some duplicate logic.

@vjeux updated to include test case. Also changed implementation to avoid some duplicate logic.
emilsjolander commented 2016-01-06 05:37:16 -08:00 (Migrated from github.com)
Copy Link

nvm this broke a lot of things in the transpiling. Fixing.

nvm this broke a lot of things in the transpiling. Fixing.
lucasr commented 2016-01-07 04:17:27 -08:00 (Migrated from github.com)
Copy Link

Nice, thanks!

Nice, thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#161
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?