DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add test support for intrinsic sized nodes #1671

Closed
mlord93 wants to merge 1 commits from export-D58307002 into main
pull from: export-D58307002
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 77 +2284 -119
mlord93 commented 2024-06-24 16:45:31 -07:00 (Migrated from github.com)
Copy Link

Summary: This diff adds support for intrinsic sizing in generated tests. This is done by importing a testing font called "Ahem" which, as used, has an exact width and height of 10px for each character. Support has been added for C++, Java, and Javascript generated tests.

Reviewed By: NickGerleman

Differential Revision: D58307002

Summary: This diff adds support for intrinsic sizing in generated tests. This is done by importing a testing font called "Ahem" which, as used, has an exact width and height of 10px for each character. Support has been added for C++, Java, and Javascript generated tests. Reviewed By: NickGerleman Differential Revision: D58307002
vercel[bot] commented 2024-06-24 16:45:34 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 3:55pm
[vc]: #aw5oft9a05P1daB8kPxHWMKhIDpTD7Ip6sGYJ5Ydbbo=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlL0hkZjVVTVlYWThnb2E0ZVJGNldpeDZDeWZDM1AiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLW1sb3JkOTMtZXhwb3J0LWQ1ODMwNzAwMi1mYm9wZW5zb3VyY2UudmVyY2VsLmFwcCIsIm5leHRDb21taXRTdGF0dXMiOiJERVBMT1lFRCIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJ5b2dhLXdlYnNpdGUtZ2l0LWZvcmstbWxvcmQ5My1leHBvcnQtZDU4MzA3MDAyLWZib3BlbnNvdXJjZS52ZXJjZWwuYXBwIn19XX0= **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/Hdf5UMYXY8goa4eRF6Wix6CyfC3P)) | [Visit Preview](https://vercel.live/open-feedback/yoga-website-git-fork-mlord93-export-d58307002-fbopensource.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-mlord93-export-d58307002-fbopensource.vercel.app?via=pr-comment-feedback-link) | Jun 26, 2024 3:55pm |
facebook-github-bot commented 2024-06-24 16:46:04 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D58307002

This pull request was **exported** from Phabricator. Differential Revision: [D58307002](https://www.internalfb.com/diff/D58307002)
facebook-github-bot commented 2024-06-26 08:52:17 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D58307002

This pull request was **exported** from Phabricator. Differential Revision: [D58307002](https://www.internalfb.com/diff/D58307002)
facebook-github-bot commented 2024-06-26 10:03:28 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@1a3bc6bfbc.

This pull request has been merged in facebook/yoga@1a3bc6bfbc09d2c6d3ccb917d43a66626c44efa8.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1671
No description provided.
Delete Branch "export-D58307002"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?