DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Make gentest-validate more graceful of different file organization #1672

Closed
NickGerleman wants to merge 1 commits from export-D58987293 into main
pull from: export-D58987293
merge into: DaddyFrosty:main
Conversation 6 Commits 1 Files Changed 7 +120 -60
NickGerleman commented 2024-06-24 21:08:12 -07:00 (Migrated from github.com)
Copy Link

Summary: This reworks gentest-validate, to be more resilient to changes like D58307002, which cause validation failures on the intrinsic sizing testing change, which currently causes failure due to the file traversal code not handling the presence of directories.

Differential Revision: D58987293

Summary: This reworks `gentest-validate`, to be more resilient to changes like D58307002, which cause [validation failures](https://github.com/facebook/yoga/actions/runs/9653979292/job/26627690870) on the intrinsic sizing testing change, which currently causes failure due to the file traversal code not handling the presence of directories. Differential Revision: D58987293
vercel[bot] commented 2024-06-24 21:08:16 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 4:51am
[vc]: #CO/0cpVHfxQL6SHAm1ib4pCJEsNhYapZS0GwM9JbLrk=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlLzkzWXR6bnZZeWdHTlF1UTJuZ0tRQUZvRXdYOEwiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLW5pY2tnZXJsZW1hbi1leHBvcnQtZC01MTAyMDAtZmJvcGVuc291cmNlLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLW5pY2tnZXJsZW1hbi1leHBvcnQtZC01MTAyMDAtZmJvcGVuc291cmNlLnZlcmNlbC5hcHAifX1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/93YtznvYygGNQuQ2ngKQAFoEwX8L)) | [Visit Preview](https://vercel.live/open-feedback/yoga-website-git-fork-nickgerleman-export-d-510200-fbopensource.vercel.app?via=pr-comment-visit-preview-link&passThrough=1) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-nickgerleman-export-d-510200-fbopensource.vercel.app?via=pr-comment-feedback-link) | Jun 25, 2024 4:51am |
facebook-github-bot commented 2024-06-24 21:08:33 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D58987293

This pull request was **exported** from Phabricator. Differential Revision: [D58987293](https://www.internalfb.com/diff/D58987293)
facebook-github-bot commented 2024-06-24 21:12:29 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D58987293

This pull request was **exported** from Phabricator. Differential Revision: [D58987293](https://www.internalfb.com/diff/D58987293)
facebook-github-bot commented 2024-06-24 21:20:34 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D58987293

This pull request was **exported** from Phabricator. Differential Revision: [D58987293](https://www.internalfb.com/diff/D58987293)
facebook-github-bot commented 2024-06-24 21:48:37 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D58987293

This pull request was **exported** from Phabricator. Differential Revision: [D58987293](https://www.internalfb.com/diff/D58987293)
facebook-github-bot commented 2024-06-26 01:28:58 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@0888b20098.

This pull request has been merged in facebook/yoga@0888b20098e27a72eb45eedc9e24943a7222a8ff.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1672
No description provided.
Delete Branch "export-D58987293"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?