DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

[bug] alignItems not working #1695

New Issue
Closed
opened 2024-09-02 11:22:45 -07:00 by trusktr · 3 comments
trusktr commented 2024-09-02 11:22:45 -07:00 (Migrated from github.com)
Copy Link

Report

Issues and Steps to Reproduce

See Playground Example

Try changing alignItems to center or flex-end and notice it is not working the same as with CSS.

Expected Behavior

Expecting it to work like in CSS. Video:

https://github.com/user-attachments/assets/5d4663d1-6b7f-44aa-b8e1-3919abdc45d6

Actual Behavior

In the yoga example, the items do not shift like in the CSS video

Link to Code

see above

# Report - [x] I have searched [existing issues](https://github.com/facebook/yoga/issues) and this is not a duplicate # Issues and Steps to Reproduce See [Playground Example](https://www.yogalayout.dev/playground?code=DwGQhgng9grgLgAgMZQHYDMCWBzAvAb3xgGcBTAdVICMARU9MGAGzmIC4E4AnGUgXz4A+AFAIEwAHJQAJqVFiExOBCakC+eQoQB3TNLgALDgCYArAAYANJoUHSOA3BMXrWsQAcw06ZlTYOAIxWNmLYYO4mrm4AViRwmOgQAMJocKSoTggA5OiqAB4AtOnSWVFaYEw4qACSaQC27Nm5pIXFpSEIzXnkXOEcWdq97u1aAiJakjKkisqq6nVgXNi+HKaWCHYOmS46eoar5gIIAPTjCpOyMypqhAtLKwhrG-bYjgfruvpGj4d8J2diC7TJTXeaLZaoVbrTavbZWXZfA5HU42IFXOa3cEPJ4wt4-D57b4WZFnYDHKSyERk8DQeCCIA) Try changing alignItems to center or flex-end and notice it is not working the same as with CSS. # Expected Behavior Expecting it to work like in CSS. Video: https://github.com/user-attachments/assets/5d4663d1-6b7f-44aa-b8e1-3919abdc45d6 # Actual Behavior In the yoga example, the items do not shift like in the CSS video # Link to Code see above
trusktr commented 2024-09-23 09:51:47 -07:00 (Migrated from github.com)
Copy Link

I deleted all my comments. There were multiple issues, but I simplified the OP to show the one main issue that might be (or hint at) the root of other issues.

I deleted all my comments. There were multiple issues, but I simplified the OP to show the one main issue that might be (or hint at) the root of other issues.
NickGerleman commented 2024-10-14 11:29:45 -07:00 (Migrated from github.com)
Copy Link

Yoga vs web for reference: https://jsfiddle.net/xkrfp2do/1/

This looks like a bug with alignContent: stretch impl.

image image
Yoga vs web for reference: https://jsfiddle.net/xkrfp2do/1/ This looks like a bug with `alignContent: stretch` impl. <img width="325" alt="image" src="https://github.com/user-attachments/assets/9cd22c32-9019-4218-a934-6652f3bb981d"> <img width="297" alt="image" src="https://github.com/user-attachments/assets/4ad496b7-6170-446e-88dd-b7acabe2cba8">
NickGerleman commented 2024-12-02 23:34:52 -08:00 (Migrated from github.com)
Copy Link

Fixed as of 3.1.0.
image

Fixed as of 3.1.0. <img width="1151" alt="image" src="https://github.com/user-attachments/assets/e2e305eb-ca6d-41a4-a8c7-40571ef9820b">
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Algorithm
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1695
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?