DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

JS bindings: Expose HadOverflow property #1773

New Issue
Open
opened 2024-12-18 13:33:12 -08:00 by ctensmeyer · 0 comments
ctensmeyer commented 2024-12-18 13:33:12 -08:00 (Migrated from github.com)
Copy Link

Report

The struct in javascript/src/Layout.h only exposes top, left, right, bottom, width, and height properties, while the C API in yoga/YGNodeLayout.h additionally has YGNodeLayoutGetHadOverflow(). Can a wrapper for YGNodeLayoutGetHadOverflow() get added to the JS bindings?

Note this isn't the Overflow style property (which is already the JS bindings), but the flag set during the layout algorithm to indicate the Node overflows.

# Report - [ X] I have searched [existing issues](https://github.com/facebook/yoga/issues) and this is not a duplicate The struct in `javascript/src/Layout.h` only exposes top, left, right, bottom, width, and height properties, while the C API in `yoga/YGNodeLayout.h` additionally has `YGNodeLayoutGetHadOverflow()`. Can a wrapper for `YGNodeLayoutGetHadOverflow()` get added to the JS bindings? Note this isn't the Overflow style property (which is already the JS bindings), but the flag set during the layout algorithm to indicate the Node overflows.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
JavaScript
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1773
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?