Reset child position/sizes before calculating layout #178

2016-03-25T14:00:11-07:00

javache commented

2016-03-25 14:00:11 -07:00

(Migrated from github.com)

For consistency with the other native versions, we should do layout reset inline with the layoutNode calculation, since layoutNode can potentially be invoked multiple times.

I'll need to remove/update the custom reset logic in React Native to make use of this when merging in that project.

This fixes #175.

Test plan: I added a new test in Layout-test.js, which passed the JS and Java version but failed in the C version. After my changes the C version also passes.

For consistency with the other native versions, we should do layout reset inline with the `layoutNode` calculation, since `layoutNode` can potentially be invoked multiple times. I'll need to remove/update the custom reset logic in React Native to make use of this when merging in that project. This fixes #175. **Test plan**: I added a new test in `Layout-test.js`, which passed the JS and Java version but failed in the C version. After my changes the C version also passes.

vjeux commented

2016-03-25 14:04:31 -07:00

(Migrated from github.com)

Looks good to me! Sorry for the trouble

javache commented

2016-03-29 03:06:37 -07:00

(Migrated from github.com)

Thanks, removed the typos.

lucasr commented

2016-03-29 03:15:57 -07:00

(Migrated from github.com)

Great, thanks for fixing this!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#178