DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add aar BUCK targets to export Litho libraries as aars #1782

Closed
mihaelao wants to merge 1 commits from export-D68152410 into main
pull from: export-D68152410
merge into: DaddyFrosty:main
Conversation 3 Commits 1 Files Changed 1 +16 -1
mihaelao commented 2025-01-24 07:12:10 -08:00 (Migrated from github.com)
Copy Link

Summary:
This adds fb_native.android_aar targets for resources that are needed by Litho at runtime and cannot be exported as jars.

  • resource modules referenced by Litho
  • Yoga library. Some dependencies required by Yoga neded to be added as "provided_deps" so they don't get exported with the aar

Reviewed By: astreet

Differential Revision: D68152410

Summary: This adds fb_native.android_aar targets for resources that are needed by Litho at runtime and cannot be exported as jars. - resource modules referenced by Litho - Yoga library. Some dependencies required by Yoga neded to be added as "provided_deps" so they don't get exported with the aar Reviewed By: astreet Differential Revision: D68152410
vercel[bot] commented 2025-01-24 07:12:15 -08:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 3:14pm
[vc]: #h+VOIn+z8Lqxq5NpjywcYwM/vRU3/wKYX3yejDD7mTo=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlLzNHWVc1d0NUU0NtMVhWeUhOY2pRQXc3ZDNrb3AiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLW1paGFlbGFvLWV4cG9ydC1kNjgxNTI0MTAtZmJvcGVuc291cmNlLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLW1paGFlbGFvLWV4cG9ydC1kNjgxNTI0MTAtZmJvcGVuc291cmNlLnZlcmNlbC5hcHAifX1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/3GYW5wCTSCm1XVyHNcjQAw7d3kop)) | [Visit Preview](https://yoga-website-git-fork-mihaelao-export-d68152410-fbopensource.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-mihaelao-export-d68152410-fbopensource.vercel.app?via=pr-comment-feedback-link) | Jan 24, 2025 3:14pm |
facebook-github-bot commented 2025-01-24 07:12:19 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D68152410

This pull request was **exported** from Phabricator. Differential Revision: [D68152410](https://www.internalfb.com/diff/D68152410)
facebook-github-bot commented 2025-01-24 08:01:34 -08:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@49ee855f99.

This pull request has been merged in facebook/yoga@49ee855f99fb67079c24d507a4ea1b6d80fa2ebf.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1782
No description provided.
Delete Branch "export-D68152410"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?