DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Update yoga aar targets #1786

Closed
mihaelao wants to merge 1 commits from export-D69455682 into main
pull from: export-D69455682
merge into: DaddyFrosty:main
Conversation 3 Commits 1 Files Changed 1 +4 -6
mihaelao commented 2025-02-12 01:42:32 -08:00 (Migrated from github.com)
Copy Link

Summary:
Follow up on comments from D68152410

  • Removes minsdk version from manifest
  • Update to MIT licence
  • Rename targets that don't export existing libs

I've looked into using yoga_java_library and adding a param to pass what libs to exclude, but ultimately provided_deps does what we need and it simpler to maintain; we still need to add the different targets because the aar needs to depend on :jni-server and not :jni.

Reviewed By: NickGerleman

Differential Revision: D69455682

Summary: Follow up on comments from D68152410 - Removes minsdk version from manifest - Update to MIT licence - Rename targets that don't export existing libs I've looked into using yoga_java_library and adding a param to pass what libs to exclude, but ultimately provided_deps does what we need and it simpler to maintain; we still need to add the different targets because the aar needs to depend on :jni-server and not :jni. Reviewed By: NickGerleman Differential Revision: D69455682
vercel[bot] commented 2025-02-12 01:42:38 -08:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 9:45am
[vc]: #vQztIDedgLiFLq1AGcshTwXuK4PGrc+RVZXaK1zAgiU=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlLzRiU3RocUdmUVlKN0dVaEdLUVpjZjFRRHBiNUIiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLW1paGFlbGFvLWV4cG9ydC1kNjk0NTU2ODItZmJvcGVuc291cmNlLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLW1paGFlbGFvLWV4cG9ydC1kNjk0NTU2ODItZmJvcGVuc291cmNlLnZlcmNlbC5hcHAifX1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/4bSthqGfQYJ7GUhGKQZcf1QDpb5B)) | [Visit Preview](https://yoga-website-git-fork-mihaelao-export-d69455682-fbopensource.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-mihaelao-export-d69455682-fbopensource.vercel.app?via=pr-comment-feedback-link) | Feb 12, 2025 9:45am |
facebook-github-bot commented 2025-02-12 01:42:44 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D69455682

This pull request was **exported** from Phabricator. Differential Revision: [D69455682](https://www.internalfb.com/diff/D69455682)
facebook-github-bot commented 2025-02-12 02:42:52 -08:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@c2ae39167e.

This pull request has been merged in facebook/yoga@c2ae39167e7152b90000e4c2402467bd537ee89a.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1786
No description provided.
Delete Branch "export-D69455682"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?