DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Enable RTTI to fix exception pointer issue on React Native #1791

Closed
cortinico wants to merge 1 commits from export-D70386744 into main
pull from: export-D70386744
merge into: DaddyFrosty:main
Conversation 9 Commits 1 Files Changed 1 +4 -4
cortinico commented 2025-02-28 03:20:32 -08:00 (Migrated from github.com)
Copy Link

Summary:
Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS.
Fixes: https://github.com/facebook/react-native/issues/48027

Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole
React Native build so it probably makes sense to have it enabled for Yoga as well.

Changelog:
[Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native

Differential Revision: D70386744

Summary: Disabling RTTI for Yoga is causing std::exception to don't work properly in OSS. Fixes: https://github.com/facebook/react-native/issues/48027 Not sure why we originally disabled RTTI for Yoga, but we have it enable for the whole React Native build so it probably makes sense to have it enabled for Yoga as well. Changelog: [Internal] [Changed] - Enable RTTI to fix exception pointer issue on React Native Differential Revision: D70386744
❤️ 1
vercel[bot] commented 2025-02-28 03:20:36 -08:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:11am
[vc]: #fms41/N9EQO/IqCNs/OQQz2N0tLYcdKdv94tGhtuE0E=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlL0VqODgzY1BBZ3dBZXpzRTVSN3RWd0xYNUYyc1AiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLWNvcnRpbmljby1leHBvcnQtZDcwMzg2NzQ0LWZib3BlbnNvdXJjZS52ZXJjZWwuYXBwIiwibmV4dENvbW1pdFN0YXR1cyI6IkRFUExPWUVEIiwibGl2ZUZlZWRiYWNrIjp7InJlc29sdmVkIjowLCJ1bnJlc29sdmVkIjowLCJ0b3RhbCI6MCwibGluayI6InlvZ2Etd2Vic2l0ZS1naXQtZm9yay1jb3J0aW5pY28tZXhwb3J0LWQ3MDM4Njc0NC1mYm9wZW5zb3VyY2UudmVyY2VsLmFwcCJ9fV19 **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/Ej883cPAgwAezsE5R7tVwLX5F2sP)) | [Visit Preview](https://yoga-website-git-fork-cortinico-export-d70386744-fbopensource.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-cortinico-export-d70386744-fbopensource.vercel.app?via=pr-comment-feedback-link) | Mar 4, 2025 9:11am |
facebook-github-bot commented 2025-02-28 03:20:44 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D70386744

This pull request was **exported** from Phabricator. Differential Revision: [D70386744](https://www.internalfb.com/diff/D70386744)
facebook-github-bot commented 2025-02-28 04:01:20 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D70386744

This pull request was **exported** from Phabricator. Differential Revision: [D70386744](https://www.internalfb.com/diff/D70386744)
facebook-github-bot commented 2025-03-03 06:02:45 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D70386744

This pull request was **exported** from Phabricator. Differential Revision: [D70386744](https://www.internalfb.com/diff/D70386744)
facebook-github-bot commented 2025-03-03 07:56:54 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D70386744

This pull request was **exported** from Phabricator. Differential Revision: [D70386744](https://www.internalfb.com/diff/D70386744)
facebook-github-bot commented 2025-03-03 10:17:32 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D70386744

This pull request was **exported** from Phabricator. Differential Revision: [D70386744](https://www.internalfb.com/diff/D70386744)
facebook-github-bot commented 2025-03-04 01:08:53 -08:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D70386744

This pull request was **exported** from Phabricator. Differential Revision: [D70386744](https://www.internalfb.com/diff/D70386744)
facebook-github-bot commented 2025-03-04 04:54:46 -08:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@1b7d2c8d48.

This pull request has been merged in facebook/yoga@1b7d2c8d48e83fb136eccc5215faeb8d54da9c3e.
mrousavy commented 2025-03-04 11:25:58 -08:00 (Migrated from github.com)
Copy Link

amazing find nicola. I'll test this!

amazing find nicola. I'll test this!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1791
No description provided.
Delete Branch "export-D70386744"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?