DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Update GHA actions/upload-artifact to v4, unbreak CI #1799

Closed
robhogan wants to merge 1 commits from export-D70986391 into main
pull from: export-D70986391
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 3 +3 -3
robhogan commented 2025-03-11 12:50:09 -07:00 (Migrated from github.com)
Copy Link

Summary:
actions/upload-artifact@v3 is deprecated and will no longer execute, causing CI to fail - eg:

https://github.com/facebook/yoga/actions/runs/13789185831/job/38564343959

See https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ for context

Differential Revision: D70986391

Summary: `actions/upload-artifact@v3` is deprecated and will no longer execute, causing CI to fail - eg: https://github.com/facebook/yoga/actions/runs/13789185831/job/38564343959 See https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ for context Differential Revision: D70986391
vercel[bot] commented 2025-03-11 12:50:10 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 8:08pm
[vc]: #cfMVriTQFcGcsru7HXqWiVvN1NTx1L5mEEVBzkwwzDQ=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJpbnNwZWN0b3JVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vZmJvcGVuc291cmNlL3lvZ2Etd2Vic2l0ZS9HTjRWMjZraDk0MjJhMldmWHRSS1BjdlA4UE1DIiwicHJldmlld1VybCI6InlvZ2Etd2Vic2l0ZS1naXQtZXhwb3J0LWQ3MDk4NjM5MS1mYm9wZW5zb3VyY2UudmVyY2VsLmFwcCIsIm5leHRDb21taXRTdGF0dXMiOiJERVBMT1lFRCIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJ5b2dhLXdlYnNpdGUtZ2l0LWV4cG9ydC1kNzA5ODYzOTEtZmJvcGVuc291cmNlLnZlcmNlbC5hcHAifSwicm9vdERpcmVjdG9yeSI6IndlYnNpdGUifV19 **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/GN4V26kh9422a2WfXtRKPcvP8PMC)) | [Visit Preview](https://yoga-website-git-export-d70986391-fbopensource.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-export-d70986391-fbopensource.vercel.app?via=pr-comment-feedback-link) | Mar 11, 2025 8:08pm |
facebook-github-bot commented 2025-03-11 13:03:37 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D70986391

This pull request was **exported** from Phabricator. Differential Revision: [D70986391](https://www.internalfb.com/diff/D70986391)
facebook-github-bot commented 2025-03-11 13:03:43 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D70986391

This pull request was **exported** from Phabricator. Differential Revision: [D70986391](https://www.internalfb.com/diff/D70986391)
facebook-github-bot commented 2025-03-11 13:46:11 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@6455a848a7.

This pull request has been merged in facebook/yoga@6455a848a76f433bdb48b2640b7f4644774c76fd.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1799
No description provided.
Delete Branch "export-D70986391"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?