DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

LayoutData - added explicit default fields values initialization #1802

Closed
inobelar wants to merge 2 commits from patch-1 into main
pull from: patch-1
merge into: DaddyFrosty:main
Conversation 5 Commits 2 Files Changed 1 +6 -6
inobelar commented 2025-03-19 08:39:28 -07:00 (Migrated from github.com)
Copy Link

Explicit defaults add 'strictness' and take the guesswork out of what's going on in places like this:

6455a848a7/yoga/algorithm/CalculateLayout.cpp (L2345)

Explicit defaults add 'strictness' and take the guesswork out of what's going on in places like this: https://github.com/facebook/yoga/blob/6455a848a76f433bdb48b2640b7f4644774c76fd/yoga/algorithm/CalculateLayout.cpp#L2345
vercel[bot] commented 2025-03-19 08:39:33 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 11:22am
[vc]: #VGTYmUVviJyVQaYZvYrERjOxnZ82RRkh3T4PVaW8jjI=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlLzQ2dlc0YzZzRXZoOUhIQVRHVUF3bUJkM0ZqbnAiLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLWlub2JlbGFyLXBhdGNoLTEtZmJvcGVuc291cmNlLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLWlub2JlbGFyLXBhdGNoLTEtZmJvcGVuc291cmNlLnZlcmNlbC5hcHAifX1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/46vW4c6sEvh9HHATGUAwmBd3Fjnp)) | [Visit Preview](https://yoga-website-git-fork-inobelar-patch-1-fbopensource.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-inobelar-patch-1-fbopensource.vercel.app?via=pr-comment-feedback-link) | Mar 20, 2025 11:22am |
NickGerleman (Migrated from github.com) reviewed 2025-03-19 12:58:45 -07:00
yoga/event/event.h
@@ -36,12 +36,12 @@ enum struct LayoutPassReason : int {
};
NickGerleman (Migrated from github.com) commented 2025-03-19 12:58:45 -07:00
Copy Link

nit: this is already default initialized

      measureCallbackReasonsCount;
nit: this is already default initialized ```suggestion measureCallbackReasonsCount; ```
NickGerleman (Migrated from github.com) approved these changes 2025-03-19 12:58:54 -07:00
facebook-github-bot commented 2025-03-22 16:02:12 -07:00 (Migrated from github.com)
Copy Link

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D71687310).
facebook-github-bot commented 2025-03-24 12:27:05 -07:00 (Migrated from github.com)
Copy Link

@NickGerleman merged this pull request in facebook/yoga@51e6095005.

@NickGerleman merged this pull request in facebook/yoga@51e6095005fd713dbfcbaf2c6296009de782d966.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
NickGerleman
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Shared with Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1802
No description provided.
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?