DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

YGPersistentNodeCloningTest #1813

Closed
NickGerleman wants to merge 1 commits from export-D75572762 into main
pull from: export-D75572762
merge into: DaddyFrosty:main
Conversation 5 Commits 1 Files Changed 1 +184
NickGerleman commented 2025-05-30 13:09:15 -07:00 (Migrated from github.com)
Copy Link

Summary:
This adds a unit test to Yoga, which emulates the model of "persistent Yoga nodes" and cloning used by React Fabric, including the private (but relied on) Yoga APIs.

It models the over-invalidation exposed in D75287261, which reproduces (due to Yoga incorrectly measuring flex-basis under fit-content, and that constraint changing when sibling changes) but this test for now sets a definite height on A, to show that we only clone what is neccesary, when measure constraints do not have to change.

Having a minimal version of Fabric's model in Yoga unit tests should make some of these interesting interactions a bit easier to debug.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D75572762

Summary: This adds a unit test to Yoga, which emulates the model of "persistent Yoga nodes" and cloning used by React Fabric, including the private (but relied on) Yoga APIs. It models the over-invalidation exposed in D75287261, which reproduces (due to Yoga incorrectly measuring flex-basis under fit-content, and that constraint changing when sibling changes) but this test for now sets a definite height on A, to show that we only clone what is neccesary, when measure constraints do not have to change. Having a minimal version of Fabric's model in Yoga unit tests should make some of these interesting interactions a bit easier to debug. Changelog: [Internal] Reviewed By: javache Differential Revision: D75572762
vercel[bot] commented 2025-05-30 13:09:18 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 2:04am
[vc]: #2soHsNOVe4MLh2dln6UpQzZ7vWZx7l4SlVr5dnI0Pb0=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJpbnNwZWN0b3JVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vZmJvcGVuc291cmNlL3lvZ2Etd2Vic2l0ZS80NFlnNHZYYUJiWnM5OHF4Nzc5QWllS0NVemdHIiwicHJldmlld1VybCI6InlvZ2Etd2Vic2l0ZS1naXQtZm9yay1uaWNrZ2VybGVtYW4tZXhwb3J0LWQtZjJlNjU0LWZib3BlbnNvdXJjZS52ZXJjZWwuYXBwIiwibmV4dENvbW1pdFN0YXR1cyI6IkRFUExPWUVEIiwibGl2ZUZlZWRiYWNrIjp7InJlc29sdmVkIjowLCJ1bnJlc29sdmVkIjowLCJ0b3RhbCI6MCwibGluayI6InlvZ2Etd2Vic2l0ZS1naXQtZm9yay1uaWNrZ2VybGVtYW4tZXhwb3J0LWQtZjJlNjU0LWZib3BlbnNvdXJjZS52ZXJjZWwuYXBwIn0sInJvb3REaXJlY3RvcnkiOiJ3ZWJzaXRlIn1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/44Yg4vXaBbZs98qx779AieKCUzgG)) | [Visit Preview](https://yoga-website-git-fork-nickgerleman-export-d-f2e654-fbopensource.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-nickgerleman-export-d-f2e654-fbopensource.vercel.app?via=pr-comment-feedback-link) | Jun 3, 2025 2:04am |
facebook-github-bot commented 2025-05-30 13:09:22 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D75572762

This pull request was **exported** from Phabricator. Differential Revision: [D75572762](https://www.internalfb.com/diff/D75572762)
facebook-github-bot commented 2025-06-02 17:15:58 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D75572762

This pull request was **exported** from Phabricator. Differential Revision: [D75572762](https://www.internalfb.com/diff/D75572762)
facebook-github-bot commented 2025-06-02 19:02:28 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D75572762

This pull request was **exported** from Phabricator. Differential Revision: [D75572762](https://www.internalfb.com/diff/D75572762)
facebook-github-bot commented 2025-06-02 19:35:40 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@1232761571.

This pull request has been merged in facebook/yoga@123276157121f8d87d1245f94cf5f87edeeb18b6.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1813
No description provided.
Delete Branch "export-D75572762"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?