DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

I think negative gap values should be allowed #1822

New Issue
Closed
opened 2025-06-26 11:49:21 -07:00 by vidjuheffex · 1 comment
vidjuheffex commented 2025-06-26 11:49:21 -07:00 (Migrated from github.com)
Copy Link

I opened this issue, but I see this is likely in the underlying Yoga library and not actually in react pdf
https://github.com/diegomura/react-pdf/issues/3180

More specifically, I think this https://github.com/facebook/yoga/pull/1405 is incorrect, while negative gap values might be unwise, they aren't "illegal" and shouldnt be clamped, and as you can see from the screenshots on the issue I opened in react-pdf, there are times when they are useful/the only way to accomplish certain layouts.

I opened this issue, but I see this is likely in the underlying Yoga library and not actually in react pdf https://github.com/diegomura/react-pdf/issues/3180 More specifically, I think this https://github.com/facebook/yoga/pull/1405 is incorrect, while negative gap values might be unwise, they aren't "illegal" and shouldnt be clamped, and as you can see from the screenshots on the issue I opened in react-pdf, there are times when they are useful/the only way to accomplish certain layouts.
NickGerleman commented 2025-06-26 11:52:30 -07:00 (Migrated from github.com)
Copy Link

The spec explicitly disallows negative values (and I am certain browsers would do the same).

https://www.w3.org/TR/css-align-3/#column-row-gap

Negative values are invalid.

The spec explicitly disallows negative values (and I am certain browsers would do the same). https://www.w3.org/TR/css-align-3/#column-row-gap > Negative values are invalid.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1822
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?