DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Make yoga/Yoga.h an umbrell header #1828

Closed
rudybear wants to merge 1 commits from export-D78692457 into main
pull from: export-D78692457
merge into: DaddyFrosty:main
Conversation 4 Commits 1 Files Changed 1 +8 -8
rudybear commented 2025-07-24 11:43:35 -07:00 (Migrated from github.com)
Copy Link

Summary:
This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header.

Changelog:
[General][Added] - Code quality fixes

Reviewed By: corporateshark

Differential Revision: D78692457

Summary: This diff makes the Yoga/Yoga.h header an umbrella header, which means that it includes all of Yoga's public headers. The code changes in each file include adding the IWYU pragma export to each header file, which is a way to tell the compiler to export the header file's symbols to other files that include it. This is necessary for the header file to be used as an umbrella header. Changelog: [General][Added] - Code quality fixes Reviewed By: corporateshark Differential Revision: D78692457
facebook-github-bot commented 2025-07-24 11:43:44 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D78692457

This pull request was **exported** from Phabricator. Differential Revision: [D78692457](https://www.internalfb.com/diff/D78692457)
vercel[bot] commented 2025-07-24 11:43:47 -07:00 (Migrated from github.com)
Copy Link

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 7:07pm
[vc]: #oVHoOqA9m4TaFdG15Get6j34aBhAqDh7dcaXaJQzwCU=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ5b2dhLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5Ijoid2Vic2l0ZSIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9mYm9wZW5zb3VyY2UveW9nYS13ZWJzaXRlL2tQMzljR3ZBOUZ5Uko0RlVzcFZOaWZEdFlhZmciLCJwcmV2aWV3VXJsIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLXJ1ZHliZWFyLWV4cG9ydC1kNzg2OTI0NTctZmJvcGVuc291cmNlLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoieW9nYS13ZWJzaXRlLWdpdC1mb3JrLXJ1ZHliZWFyLWV4cG9ydC1kNzg2OTI0NTctZmJvcGVuc291cmNlLnZlcmNlbC5hcHAifX1dfQ== **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **yoga-website** | ✅ Ready ([Inspect](https://vercel.com/fbopensource/yoga-website/kP39cGvA9FyRJ4FUspVNifDtYafg)) | [Visit Preview](https://yoga-website-git-fork-rudybear-export-d78692457-fbopensource.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/yoga-website-git-fork-rudybear-export-d78692457-fbopensource.vercel.app?via=pr-comment-feedback-link) | Jul 24, 2025 7:07pm |
facebook-github-bot commented 2025-07-24 12:04:44 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D78692457

This pull request was **exported** from Phabricator. Differential Revision: [D78692457](https://www.internalfb.com/diff/D78692457)
facebook-github-bot commented 2025-07-24 16:56:02 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@9f2a9476e5.

This pull request has been merged in facebook/yoga@9f2a9476e5a8fdd7dec0891d69077eff6265c998.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#1828
No description provided.
Delete Branch "export-D78692457"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?