Correctly size cross axis when measuring flex basis #199

2016-06-29T07:10:06-07:00

emilsjolander commented

2016-06-29 07:10:06 -07:00

(Migrated from github.com)

Nodes were measured with the assumption of being text nodes (height depends on width) when determining flex basis. This is not always true. Even when we are just interested in the main axis (flex basis) we need to correctly constrain the cross axis.
Some tests were wrong. Measuring texts.big and expecting it to have textSizes.smallHeight which doesn't make a lot of sense.

- Nodes were measured with the assumption of being text nodes (height depends on width) when determining flex basis. This is not always true. Even when we are just interested in the main axis (flex basis) we need to correctly constrain the cross axis. - Some tests were wrong. Measuring texts.big and expecting it to have textSizes.smallHeight which doesn't make a lot of sense.

rigdern commented

2016-07-05 18:26:13 -07:00

(Migrated from github.com)

Some tests were wrong. Measuring texts.big and expecting it to have textSizes.smallHeight which doesn't make a lot of sense.

In the context of texts.big, I think that smallHeight means that the text fits on one line whereas bigHeight means that the text wrapped and takes up multiple lines.

> Some tests were wrong. Measuring texts.big and expecting it to have textSizes.smallHeight which doesn't make a lot of sense. In the context of `texts.big`, I think that `smallHeight` means that the text fits on one line whereas `bigHeight` means that the text wrapped and takes up multiple lines.

emilsjolander commented

2016-07-08 05:38:09 -07:00

(Migrated from github.com)

@rigdern Interesting, I had not thought of that. Super confusing. With that in mind i'll have another look. thanks

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#199