DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

css_applyLayout crack #236

New Issue
Closed
opened 2016-10-29 07:02:40 -07:00 by singno · 5 comments
singno commented 2016-10-29 07:02:40 -07:00 (Migrated from github.com)
Copy Link

image

image

![image](https://cloud.githubusercontent.com/assets/5654690/19830092/4c5b62f6-9e23-11e6-8c0b-d2604274a040.png) ![image](https://cloud.githubusercontent.com/assets/5654690/19830096/5b87c080-9e23-11e6-8827-969271633d7e.png)
emilsjolander commented 2016-10-29 14:21:50 -07:00 (Migrated from github.com)
Copy Link

@dshahidehpour Can you take a look?

@dshahidehpour Can you take a look?
gimenete commented 2016-10-30 12:04:02 -07:00 (Migrated from github.com)
Copy Link

It fails because node->children is NULL. The problem seems to have been introduced here 01c2ac3369 (diff-937e78d20ebabc2f92fe6f07dc70d4a3L198)

Using node->children = CSSNodeListNew(4); in CSSNodeInit works for me but it's not the optimal solution.

It fails because `node->children` is NULL. The problem seems to have been introduced here https://github.com/facebook/css-layout/commit/01c2ac3369b6e403e5f7a24b91a01b7bb792eed7?diff=unified#diff-937e78d20ebabc2f92fe6f07dc70d4a3L198 Using `node->children = CSSNodeListNew(4);` in `CSSNodeInit` works for me but it's not the optimal solution.
d16r commented 2016-10-31 07:21:32 -07:00 (Migrated from github.com)
Copy Link

Thanks for spotting! I'm adding a fix right now.

Thanks for spotting! I'm adding a fix right now.
👍 1
d16r commented 2016-10-31 13:19:49 -07:00 (Migrated from github.com)
Copy Link

Just landed a fix with ced779b259

Just landed a fix with ced779b25966448feb9bd792efedd29dfa6ab9e0
gimenete commented 2016-11-03 04:04:23 -07:00 (Migrated from github.com)
Copy Link

It works! Thanks :)

It works! Thanks :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#236
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?