DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Tests are failing on firefox 31.3.0 #25

New Issue
Closed
opened 2015-01-30 03:30:17 -08:00 by m1el · 4 comments
m1el commented 2015-01-30 03:30:17 -08:00 (Migrated from github.com)
Copy Link

To reproduce: open RunLayoutTests.html in firefox.

all tests are failing in firefox

To reproduce: open RunLayoutTests.html in firefox. ![all tests are failing in firefox](http://i.imgur.com/DCK78I2.png)
vjeux commented 2015-01-30 10:50:30 -08:00 (Migrated from github.com)
Copy Link

Yeah, I tried to get it working on Firefox but couldn't get it to work 100% of the time so I gave up. Pull requests to fix it are more than welcome

Yeah, I tried to get it working on Firefox but couldn't get it to work 100% of the time so I gave up. Pull requests to fix it are more than welcome
1genius commented 2015-02-04 04:48:51 -08:00 (Migrated from github.com)
Copy Link

What is the problem with firefox? I would like to try and fix the bug.

What is the problem with firefox? I would like to try and fix the bug.
vjeux commented 2015-02-04 08:21:11 -08:00 (Migrated from github.com)
Copy Link

If I remember correctly, it had to do with the creation of the iframe and setting css. I couldn't get the timings right.

https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83

If I remember correctly, it had to do with the creation of the iframe and setting css. I couldn't get the timings right. https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83
1genius commented 2015-02-09 08:40:41 -08:00 (Migrated from github.com)
Copy Link

Hi Christopher,

I’m writing because I need your help. I was looking at the java code for iframe. I would like very much to help you and other java developers on the Github site but my java is at the basic level. I got an A+ in the basic course. How do I get to your level? Your program in iframe uses function but I know that methods in java start with public static void or public static int. I would really appreciate your advice.

Thank you,
Ben

On Feb 4, 2015, at 11:21 AM, Christopher Chedeau notifications@github.com wrote:

If I remember correctly, it had to do with the creation of the iframe and setting css. I couldn't get the timings right.

https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83 https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83
—
Reply to this email directly or view it on GitHub https://github.com/facebook/css-layout/issues/25#issuecomment-72885114.

Hi Christopher, I’m writing because I need your help. I was looking at the java code for iframe. I would like very much to help you and other java developers on the Github site but my java is at the basic level. I got an A+ in the basic course. How do I get to your level? Your program in iframe uses function but I know that methods in java start with public static void or public static int. I would really appreciate your advice. Thank you, Ben > On Feb 4, 2015, at 11:21 AM, Christopher Chedeau notifications@github.com wrote: > > If I remember correctly, it had to do with the creation of the iframe and setting css. I couldn't get the timings right. > > https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83 https://github.com/facebook/css-layout/blob/master/src/Layout-test-utils.js#L52-L83 > — > Reply to this email directly or view it on GitHub https://github.com/facebook/css-layout/issues/25#issuecomment-72885114.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#25
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?