DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add basic Xamarin.iOS support #280

Closed
rmarinho wants to merge 20 commits from add-xamarin-ios into master
pull from: add-xamarin-ios
merge into: DaddyFrosty:master
Conversation 24 Commits 20 Files Changed 40 +2373 -49
rmarinho commented 2016-12-08 11:11:44 -08:00 (Migrated from github.com)
Copy Link

Basic work to show usage on Xamarin iOS , contains implementation of YogaKit and sample project.

Should help on #276

Basic work to show usage on Xamarin iOS , contains implementation of YogaKit and sample project. Should help on #276
facebook-github-bot commented 2016-12-08 11:11:48 -08:00 (Migrated from github.com)
Copy Link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! **If you are contributing on behalf of someone else (eg your employer)**: the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.
facebook-github-bot commented 2016-12-08 11:12:26 -08:00 (Migrated from github.com)
Copy Link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
facebook-github-bot commented 2016-12-10 11:12:31 -08:00 (Migrated from github.com)
Copy Link

@rmarinho updated the pull request - view changes

@rmarinho updated the pull request - [view changes](https://github.com/facebook/yoga/pull/280/files/b2b59b6d0e425513504efe02288d9fcc0d00ad38..258ca0bc69dd6c70294a5d78de2dd0396120de8e)
facebook-github-bot commented 2016-12-10 11:42:55 -08:00 (Migrated from github.com)
Copy Link

@rmarinho updated the pull request - view changes

@rmarinho updated the pull request - [view changes](https://github.com/facebook/yoga/pull/280/files/258ca0bc69dd6c70294a5d78de2dd0396120de8e..fb8ef5af3016fd475b036822f1c042ce3a0984bc)
facebook-github-bot commented 2016-12-10 16:40:41 -08:00 (Migrated from github.com)
Copy Link

@rmarinho updated the pull request - view changes

@rmarinho updated the pull request - [view changes](https://github.com/facebook/yoga/pull/280/files/fb8ef5af3016fd475b036822f1c042ce3a0984bc..8a343145a84669a3b49f706ccac27d81eb32a411)
emilsjolander commented 2016-12-15 03:02:26 -08:00 (Migrated from github.com)
Copy Link

@splhack Can you have a look?

@splhack Can you have a look?
facebook-github-bot commented 2016-12-15 16:15:58 -08:00 (Migrated from github.com)
Copy Link

@rmarinho updated the pull request - view changes

@rmarinho updated the pull request - [view changes](https://github.com/facebook/yoga/pull/280/files/8a343145a84669a3b49f706ccac27d81eb32a411..a316917097d5c52bb3c08ae5b5017c55eb3af5ee)
splhack (Migrated from github.com) requested changes 2016-12-15 23:10:33 -08:00
splhack (Migrated from github.com) left a comment
Copy Link

I think it would be good to keep csharp/Facebook.Yoga simple. What do you think of this directory hierarchy?

  • csharp/Xamarin.iOS [New]
  • csharp/Xamarin.Mac [New]
  • csharp/Facebook.Yoga
  • csharp/tests
  • csharp/Yoga
I think it would be good to keep csharp/Facebook.Yoga simple. What do you think of this directory hierarchy? - csharp/Xamarin.iOS [New] - csharp/Xamarin.Mac [New] - csharp/Facebook.Yoga - csharp/tests - csharp/Yoga
.gitignore
@@ -6,4 +6,3 @@
/.buckd
/gentest/test.html
.buckversion
splhack (Migrated from github.com) commented 2016-12-15 23:04:27 -08:00
Copy Link

Move to csharp/.gitignore

Move to csharp/.gitignore
csharp/Facebook.Yoga/Native.cs
splhack (Migrated from github.com) commented 2016-12-15 22:05:01 -08:00
Copy Link

It will be fixed in #277, can you revert changes of csharp/Facebook.Yoga/Native.cs, csharp/Facebook.Yoga/YogaLogger.cs, csharp/Facebook.Yoga/YogaNode.cs?

It will be fixed in #277, can you revert changes of csharp/Facebook.Yoga/Native.cs, csharp/Facebook.Yoga/YogaLogger.cs, csharp/Facebook.Yoga/YogaNode.cs?
csharp/Facebook.Yoga/ios/ApiDefinition.cs
splhack (Migrated from github.com) commented 2016-12-15 22:07:42 -08:00
Copy Link

Apparently we need empty ApiDefinition.cs but don't bind static lib. Can you update the comments?

Apparently we need empty ApiDefinition.cs but don't bind static lib. Can you update the comments?
csharp/Facebook.Yoga/ios/CustomBuildAction.targets
splhack (Migrated from github.com) commented 2016-12-15 23:00:13 -08:00
Copy Link

With #286, we can use the fat static library buck-out/gen/csharp/yoganet-ios/libyoga.a that includes iOS simulator 64bit, arm64 and armv7.

With #286, we can use the fat static library `buck-out/gen/csharp/yoganet-ios/libyoga.a` that includes iOS simulator 64bit, arm64 and armv7.
rmarinho (Migrated from github.com) reviewed 2016-12-16 05:54:36 -08:00
csharp/Facebook.Yoga/ios/CustomBuildAction.targets
rmarinho (Migrated from github.com) commented 2016-12-16 05:54:36 -08:00
Copy Link

it didn't worked for me the 1st time.. i m going try again..

it didn't worked for me the 1st time.. i m going try again..
rmarinho commented 2016-12-16 05:55:48 -08:00 (Migrated from github.com)
Copy Link

Yap, i agree with the new hierarchy, will change.

Yap, i agree with the new hierarchy, will change.
rmarinho (Migrated from github.com) reviewed 2016-12-16 06:35:50 -08:00
csharp/Facebook.Yoga/Native.cs
rmarinho (Migrated from github.com) commented 2016-12-16 06:35:50 -08:00
Copy Link

Done

Done
facebook-github-bot commented 2016-12-16 06:36:15 -08:00 (Migrated from github.com)
Copy Link

@rmarinho updated the pull request - view changes

@rmarinho updated the pull request - [view changes](https://github.com/facebook/yoga/pull/280/files/a316917097d5c52bb3c08ae5b5017c55eb3af5ee..af0baaf597653cb5eb63e95e7628deb7ade44f5c)
rmarinho (Migrated from github.com) reviewed 2016-12-16 06:36:54 -08:00
csharp/Facebook.Yoga/ios/CustomBuildAction.targets
rmarinho (Migrated from github.com) commented 2016-12-16 06:36:54 -08:00
Copy Link

Oh right, i pulled the new PR that does the fat lib and it works, we will need to get #286 in.

Oh right, i pulled the new PR that does the fat lib and it works, we will need to get #286 in.
facebook-github-bot commented 2016-12-16 06:46:52 -08:00 (Migrated from github.com)
Copy Link

@rmarinho updated the pull request - view changes

@rmarinho updated the pull request - [view changes](https://github.com/facebook/yoga/pull/280/files/af0baaf597653cb5eb63e95e7628deb7ade44f5c..4e5e200c7a149ca7b3be1be4968bc9a9a9d5a9cc)
rmarinho commented 2016-12-16 11:40:10 -08:00 (Migrated from github.com)
Copy Link

All changes were made i think. Ready for another review.

All changes were made i think. Ready for another review.
facebook-github-bot commented 2016-12-16 11:42:23 -08:00 (Migrated from github.com)
Copy Link

@rmarinho updated the pull request - view changes

@rmarinho updated the pull request - [view changes](https://github.com/facebook/yoga/pull/280/files/4e5e200c7a149ca7b3be1be4968bc9a9a9d5a9cc..78bc89349d3ef401e81bfba1f736a976b636174a)
rmarinho commented 2016-12-19 12:50:00 -08:00 (Migrated from github.com)
Copy Link

@splhack Can you take another look, next step after get this in is to work on a Nuget

@splhack Can you take another look, next step after get this in is to work on a Nuget
facebook-github-bot commented 2016-12-19 15:33:31 -08:00 (Migrated from github.com)
Copy Link

@rmarinho updated the pull request - view changes

@rmarinho updated the pull request - [view changes](https://github.com/facebook/yoga/pull/280/files/78bc89349d3ef401e81bfba1f736a976b636174a..57b042feb1d415288911f7f6a26571237a8e8bee)
emilsjolander commented 2016-12-21 01:05:02 -08:00 (Migrated from github.com)
Copy Link

@rmarinho It is holiday season so this might take a while to get fully reviews and merged 👍

@rmarinho It is holiday season so this might take a while to get fully reviews and merged 👍
splhack commented 2016-12-21 11:09:21 -08:00 (Migrated from github.com)
Copy Link

@rmarinho I'm thinking to merge #283 first. Do you mind to take a look at #283? I think Xamarin.iOS can use csharp/Facebook.Yoga/Facebook.Yoga.Shared.shproj as well (Add Facebook.Yoga.Shared into Facebook.Yoga.iOS References)

@rmarinho I'm thinking to merge #283 first. Do you mind to take a look at #283? I think Xamarin.iOS can use `csharp/Facebook.Yoga/Facebook.Yoga.Shared.shproj` as well (Add `Facebook.Yoga.Shared` into `Facebook.Yoga.iOS` References)
rmarinho commented 2016-12-21 14:00:06 -08:00 (Migrated from github.com)
Copy Link

Yap seems good, i will rebase and make changes once that one is in.

Yap seems good, i will rebase and make changes once that one is in.
emilsjolander commented 2016-12-22 01:35:08 -08:00 (Migrated from github.com)
Copy Link

Want to make sure you are aware of changes being made to the iOS wrapper currently as it might effect this PR https://github.com/facebook/yoga/pull/289

Want to make sure you are aware of changes being made to the iOS wrapper currently as it might effect this PR https://github.com/facebook/yoga/pull/289
emilsjolander commented 2017-01-05 08:12:57 -08:00 (Migrated from github.com)
Copy Link

https://github.com/facebook/yoga/pull/283 has been merged now

https://github.com/facebook/yoga/pull/283 has been merged now
rmarinho commented 2017-01-05 10:29:04 -08:00 (Migrated from github.com)
Copy Link

yap going to work on this tonight.

yap going to work on this tonight.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
splhack
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#280
No description provided.
Delete Branch "add-xamarin-ios"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?