DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Transform the Count enum values into private constants #292

Closed
hartbit wants to merge 1 commits from private-count into master
pull from: private-count
merge into: DaddyFrosty:master
Conversation 3 Commits 1 Files Changed 4 +43 -21
hartbit commented 2016-12-19 11:10:33 -08:00 (Migrated from github.com)
Copy Link

Hides implementation details for the C, Objective-C and Swift APIs.

Hides implementation details for the C, Objective-C and Swift APIs.
emilsjolander commented 2016-12-19 11:59:46 -08:00 (Migrated from github.com)
Copy Link

Awesome! Will merge tomorrow

Awesome! Will merge tomorrow
facebook-github-bot commented 2016-12-20 00:30:37 -08:00 (Migrated from github.com)
Copy Link

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D4351523).
emilsjolander commented 2016-12-20 01:52:12 -08:00 (Migrated from github.com)
Copy Link

Changing this a bit before landing. Some RN stuff was depending on the count so I moved the defines into YGEnums.h

Changing this a bit before landing. Some RN stuff was depending on the count so I moved the defines into YGEnums.h

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#292
No description provided.
Delete Branch "private-count"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?