DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Switched to using SafeHandle for native code interrupt #297

Closed
itsff wants to merge 1 commits from fix/issue_295 into master
pull from: fix/issue_295
merge into: DaddyFrosty:master
Conversation 5 Commits 1 Files Changed 3 +97 -79
itsff commented 2016-12-22 22:08:51 -08:00 (Migrated from github.com)
Copy Link

This PR fixes issue #295

  • Created a new internal YGNodeHandle class extending SafeHandle.
  • YogaNode now stores a reference to YGNodeHandle.
  • Removed finalizer from YogaNode.
  • Pulling in System.Runtime.Handles 4.3.0.
This PR fixes issue #295 - Created a new internal YGNodeHandle class extending SafeHandle. - YogaNode now stores a reference to YGNodeHandle. - Removed finalizer from YogaNode. - Pulling in System.Runtime.Handles 4.3.0.
facebook-github-bot commented 2016-12-22 23:24:57 -08:00 (Migrated from github.com)
Copy Link

@splhack has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@splhack has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D4365462).
woehrl01 (Migrated from github.com) requested changes 2016-12-23 01:08:48 -08:00
csharp/Facebook.Yoga/Native.cs
@@ -23,0 +37,4 @@
protected override bool ReleaseHandle()
{
Native.YGNodeFree(this.handle);
GC.KeepAlive(this);
woehrl01 (Migrated from github.com) commented 2016-12-22 22:13:50 -08:00
Copy Link

Out of curiosity, why do we need the GC.KeepAlive here?

Out of curiosity, why do we need the GC.KeepAlive here?
csharp/Facebook.Yoga/Native.cs
@@ -99,3 +121,3 @@
[DllImport(DllName)]
public static extern void YGNodeSetHasNewLayout(IntPtr node, [MarshalAs(UnmanagedType.I1)] bool hasNewLayout);
public static extern void YGNodeSetHasNewLayout(YGNodeHandle node, [MarshalAs(UnmanagedType.I1)] bool hasNewLayout);
woehrl01 (Migrated from github.com) commented 2016-12-22 22:12:54 -08:00
Copy Link

I think this must return only intptr as we don't own the underlying node here.

I think this must return only intptr as we don't own the underlying node here.
splhack (Migrated from github.com) reviewed 2016-12-23 07:55:40 -08:00
csharp/Facebook.Yoga/Native.cs
@@ -99,3 +121,3 @@
[DllImport(DllName)]
public static extern void YGNodeSetHasNewLayout(IntPtr node, [MarshalAs(UnmanagedType.I1)] bool hasNewLayout);
public static extern void YGNodeSetHasNewLayout(YGNodeHandle node, [MarshalAs(UnmanagedType.I1)] bool hasNewLayout);
splhack (Migrated from github.com) commented 2016-12-23 07:55:40 -08:00
Copy Link

I'll remove this declaration in merge commit since managed code doesn't use it

I'll remove this declaration in merge commit since managed code doesn't use it
itsff (Migrated from github.com) reviewed 2016-12-23 10:06:04 -08:00
csharp/Facebook.Yoga/Native.cs
@@ -99,3 +121,3 @@
[DllImport(DllName)]
public static extern void YGNodeSetHasNewLayout(IntPtr node, [MarshalAs(UnmanagedType.I1)] bool hasNewLayout);
public static extern void YGNodeSetHasNewLayout(YGNodeHandle node, [MarshalAs(UnmanagedType.I1)] bool hasNewLayout);
itsff (Migrated from github.com) commented 2016-12-23 10:06:04 -08:00
Copy Link

You guys beat me to it. Thank you for noticing this one (@woehrl01) and removing it (@splhack). It could have caused some confusion and lifetime problems. We should similarly remove YGNodeSetContext and YGNodeSetContext since this functionality is achieved by the YogaNode::Data property.

You guys beat me to it. Thank you for noticing this one (@woehrl01) and removing it (@splhack). It could have caused some confusion and lifetime problems. We should similarly remove `YGNodeSetContext` and `YGNodeSetContext` since this functionality is achieved by the `YogaNode::Data` property.
itsff (Migrated from github.com) reviewed 2016-12-23 10:06:59 -08:00
csharp/Facebook.Yoga/Native.cs
@@ -23,0 +37,4 @@
protected override bool ReleaseHandle()
{
Native.YGNodeFree(this.handle);
GC.KeepAlive(this);
itsff (Migrated from github.com) commented 2016-12-23 10:06:59 -08:00
Copy Link

Likely not necessary, but I wasn't sure of the implementation of the parent class. Shouldn't hurt.

Likely not necessary, but I wasn't sure of the implementation of the parent class. Shouldn't hurt.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
woehrl01
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#297
No description provided.
Delete Branch "fix/issue_295"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?