DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Carthage and CocoaPods support #309

Closed
guidomb wants to merge 5 commits from cocoapods-support into master
pull from: cocoapods-support
merge into: DaddyFrosty:master
Conversation 18 Commits 5 Files Changed 24 +862 -5454
guidomb commented 2016-12-28 08:37:27 -08:00 (Migrated from github.com)
Copy Link

This is first attempt to add support for CocoaPods. It is currently not working because CocoaPods requires a valid semver number (and a corresponding git tag) as the library version.

This is based on #305 and should be merged after that PR is merged.

@emilsjolander @dshahidehpour Please check if the author information in the YogaKit.podspec file is correct.

Once this PR is merged in order for people to actually be able to install this using CocoaPods, the pod must be published to CocoaPods' trunk. Which requires to have an account. For more information check https://guides.cocoapods.org/making/getting-setup-with-trunk.html.

Also keep in mind that every time you make a new release you need to update the version property inside YogaKit.podspec and publish a new version to trunk.

This is first attempt to add support for CocoaPods. It is currently not working because CocoaPods requires a valid semver number (and a corresponding git tag) as the library version. This is based on #305 and should be merged after that PR is merged. @emilsjolander @dshahidehpour Please check if the author information in the `YogaKit.podspec` file is correct. Once this PR is merged in order for people to actually be able to install this using CocoaPods, the pod must be published to CocoaPods' trunk. Which requires to have an account. For more information check https://guides.cocoapods.org/making/getting-setup-with-trunk.html. Also keep in mind that every time you make a new release you need to update the `version` property inside `YogaKit.podspec` and publish a new version to trunk.
d16r (Migrated from github.com) reviewed 2016-12-28 08:44:41 -08:00
YogaKit/YogaKit.podspec
@@ -0,0 +1,21 @@
Pod::Spec.new do |spec|
d16r (Migrated from github.com) commented 2016-12-28 08:44:41 -08:00
Copy Link

dshahidehpour@gmail.com ;)

dshahidehpour@gmail.com ;)
d16r (Migrated from github.com) reviewed 2016-12-28 08:46:23 -08:00
YogaKit/YogaKit.podspec
@@ -0,0 +1,21 @@
Pod::Spec.new do |spec|
d16r (Migrated from github.com) commented 2016-12-28 08:46:23 -08:00
Copy Link

YogaKit is a view layout library which is powered by Yoga, a layout engine which implements Flexbox.

YogaKit is a view layout library which is powered by Yoga, a layout engine which implements Flexbox.
d16r (Migrated from github.com) reviewed 2016-12-28 08:48:13 -08:00
YogaKit/YogaKitSample/AppDelegate.h
@@ -0,0 +12,4 @@
@property (strong, nonatomic) UIWindow *window;
d16r (Migrated from github.com) commented 2016-12-28 08:48:13 -08:00
Copy Link

nit: delete

nit: delete
d16r (Migrated from github.com) reviewed 2016-12-28 08:48:49 -08:00
YogaKit/YogaKitSample/AppDelegate.m
@@ -0,0 +6,4 @@
* LICENSE-examples file in the root directory of this source tree.
*/
#import "AppDelegate.h"
d16r (Migrated from github.com) commented 2016-12-28 08:48:49 -08:00
Copy Link

Do we have to regenerate this? Let's revert this.

Do we have to regenerate this? Let's revert this.
d16r (Migrated from github.com) requested changes 2016-12-28 08:51:48 -08:00
d16r (Migrated from github.com) left a comment
Copy Link

@guidomb, this is amazing! I left a few comments.

@guidomb, this is amazing! I left a few comments.
guidomb (Migrated from github.com) reviewed 2016-12-28 09:21:12 -08:00
YogaKit/YogaKit.podspec
@@ -0,0 +1,21 @@
Pod::Spec.new do |spec|
guidomb (Migrated from github.com) commented 2016-12-28 09:21:12 -08:00
Copy Link

I've copied pasted that description from the one that appears in Yoga's GitHub repository. Should I change it anyways?

I've copied pasted that description from the one that appears in Yoga's GitHub repository. Should I change it anyways?
guidomb commented 2016-12-28 09:24:29 -08:00 (Migrated from github.com)
Copy Link

@dshahidehpour You made some comments in files that are originally part of @hartbit PR, #305 . For some reason I could not make hartbit/carthage-support as the target branch for this PR (GitHub did not show @hartbit's fork as an option and I couldn't fork his repo because I've already had a fork of yoga). I think those suggestion should be addressed in #305. Sorry for the extra work in the review process

@dshahidehpour You made some comments in files that are originally part of @hartbit PR, #305 . For some reason I could not make `hartbit/carthage-support` as the target branch for this PR (GitHub did not show @hartbit's fork as an option and I couldn't fork his repo because I've already had a fork of yoga). I think those suggestion should be addressed in #305. Sorry for the extra work in the review process
👍 1
hartbit commented 2016-12-28 11:49:58 -08:00 (Migrated from github.com)
Copy Link

@guidomb but as you improved on my PR, wouldn't it be better to rename this PR Cocoapods + Carthage support and fix everything here?

@guidomb but as you improved on my PR, wouldn't it be better to rename this PR Cocoapods + Carthage support and fix everything here?
guidomb commented 2016-12-28 11:52:20 -08:00 (Migrated from github.com)
Copy Link

@hartbit If you agree with that, sure. In that case I would suggest closing the other PR and focus on trying to fix the buck build and the comments suggested by @dshahidehpour here.

@hartbit If you agree with that, sure. In that case I would suggest closing the other PR and focus on trying to fix the buck build and the comments suggested by @dshahidehpour here.
d16r commented 2017-01-09 09:10:23 -08:00 (Migrated from github.com)
Copy Link

@guidomb Any update on this? The changes to add swift support have landed, so, you probably won't run into as many (if any) rebase problems.

@guidomb Any update on this? The changes to add swift support have landed, so, you probably won't run into as many (if any) rebase problems.
guidomb commented 2017-01-09 12:23:41 -08:00 (Migrated from github.com)
Copy Link

@dshahidehpour Sorry, I've been on vacations the last week. Cool that #322 has been merged!!! I'll try to get this working tomorrow. I'll let you know if I had any issues.

Have you defined a version number that should be used in the CocoaPods podspec file?

@dshahidehpour Sorry, I've been on vacations the last week. Cool that #322 has been merged!!! I'll try to get this working tomorrow. I'll let you know if I had any issues. Have you defined a version number that should be used in the CocoaPods podspec file?
emilsjolander commented 2017-01-09 12:28:40 -08:00 (Migrated from github.com)
Copy Link

@guidomb No defined a version yet. I'll do that tomorrow! Thanks for reminding me. Will most likely be version 1.0.0 but i'll have to discuss it with some others.

@guidomb No defined a version yet. I'll do that tomorrow! Thanks for reminding me. Will most likely be version `1.0.0` but i'll have to discuss it with some others.
emilsjolander commented 2017-01-10 12:55:14 -08:00 (Migrated from github.com)
Copy Link

@guidomb lets wait on #328 to merge this.

@guidomb lets wait on #328 to merge this.
guidomb commented 2017-01-10 12:57:16 -08:00 (Migrated from github.com)
Copy Link

OK, I was about to start working on it. I'll subscribe to #328 and get back to this once that one is merged. Thanks for letting me know!

OK, I was about to start working on it. I'll subscribe to #328 and get back to this once that one is merged. Thanks for letting me know!
d16r commented 2017-01-18 09:31:04 -08:00 (Migrated from github.com)
Copy Link

@guidomb #328 is going to be closed momentarily, any chance we could start on this again? @emilsjolander can help with the versioning :)

@guidomb #328 is going to be closed momentarily, any chance we could start on this again? @emilsjolander can help with the versioning :)
guidomb commented 2017-01-18 09:32:05 -08:00 (Migrated from github.com)
Copy Link

I'll try to work on this tomorrow. Will #328 be merged into master?

I'll try to work on this tomorrow. Will #328 be merged into `master`?
d16r commented 2017-01-18 09:36:30 -08:00 (Migrated from github.com)
Copy Link

yeahp!

yeahp!
guidomb commented 2017-01-22 19:42:32 -08:00 (Migrated from github.com)
Copy Link

I've made a new PR to address this -> https://github.com/facebook/yoga/pull/352

I've made a new PR to address this -> https://github.com/facebook/yoga/pull/352

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
d16r
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#309
No description provided.
Delete Branch "cocoapods-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?