Carthage Support #361

New Issue

2017-01-27T11:38:25-08:00

d16r commented

2017-01-27 11:38:25 -08:00

(Migrated from github.com)

YogaKit needs Carthage Support. There was some discussion about it in #352

👍 7

guidomb commented

2017-01-30 10:15:28 -08:00

(Migrated from github.com)

What is the best way to move this forward? In #352 you mentioned that you guys needed to modify the Xcode project file and Info.plist. Something related with how you things internally in facebook.

d16r commented

2017-01-30 12:30:06 -08:00

(Migrated from github.com)

@guidomb I would go ahead and put up a new pull request. I will work in parallel to unblock the diff.

guidomb commented

2017-03-26 16:19:49 -07:00

(Migrated from github.com)

@dshahidehpour I'll still like to have Carthage support. What can I do to help? Been trying to create an Xcode project but I having some issue to create a framework without modifying how C header files are included

d16r commented

2017-03-27 12:20:24 -07:00

(Migrated from github.com)

Can you paste the error you are running into? Sorry I haven't responded, haven't been able to focus on yoga in a bit.

guidomb commented

2017-03-29 06:54:14 -07:00

(Migrated from github.com)

The main blocker I see is that all the Objective-C code includes yoga using angle brackets imports, #import <yoga/YGEnums.h>. This does not play nice with frameworks. You can sort of get around this by playing with "Header Search Path", "Library Search Path" and "Other C Flags" build setting options. I mean, you can get it to compile but when you try to import the resulting framework into another project you get errors saying that yoga/YGEnums.h cannot be found.

I'm no expert with Xcode build settings but I think using angle brackets imports is not an option if you want to do a framework. I understand this is done this way because of how Buck works, Am I correct?

Would it be possible for you guys to create an Xcode project that is able to build a framework project and then modify the Buck file to play nice with your infra? You (or @emilsjolander) created an Xcode project but then reverted the change. What was the problem there?

The main blocker I see is that all the Objective-C code includes yoga using angle brackets imports, `#import <yoga/YGEnums.h>`. This does not play nice with frameworks. You can sort of get around this by playing with "Header Search Path", "Library Search Path" and "Other C Flags" build setting options. I mean, you can get it to compile but when you try to import the resulting framework into another project you get errors saying that `yoga/YGEnums.h` cannot be found. I'm no expert with Xcode build settings but I think using angle brackets imports is not an option if you want to do a framework. I understand this is done this way because of how Buck works, Am I correct? Would it be possible for you guys to create an Xcode project that is able to build a framework project and then modify the Buck file to play nice with your infra? You (or @emilsjolander) created an Xcode project but then reverted the change. What was the problem there?

jp-dubey07 commented

2018-08-24 04:34:37 -07:00

(Migrated from github.com)

We need Carthage support for YogaKit.

chchrn commented

2019-09-07 08:24:01 -07:00

(Migrated from github.com)

Hi guys, is there any progress on integrating Carthage?

NickGerleman commented

2023-01-24 18:31:52 -08:00

(Migrated from github.com)

I don't think we'll want to move forward with this, vs CocoaPods and/or SPM.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#361