DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

[C#][iOS] Fix callbacks on AOT #388

Closed
splhack wants to merge 5 commits from aot into master
pull from: aot
merge into: DaddyFrosty:master
Conversation 11 Commits 5 Files Changed 4 +145 -25
splhack commented 2017-02-10 13:52:16 -08:00 (Migrated from github.com)
Copy Link

Based on the idea of #386 by @rmarinho

Based on the idea of #386 by @rmarinho
rmarinho commented 2017-02-10 14:05:57 -08:00 (Migrated from github.com)
Copy Link

Don't we need to free the handle? i think we might need IDisposable , free the handle on Dispose, and call Dispose(false) on the Destructor , we can clear parent weak reference too. i think it will help fix the test failing on iOS for parent destructor.

Don't we need to free the handle? i think we might need IDisposable , free the handle on Dispose, and call Dispose(false) on the Destructor , we can clear parent weak reference too. i think it will help fix the test failing on iOS for parent destructor.
splhack commented 2017-02-10 14:19:30 -08:00 (Migrated from github.com)
Copy Link

In my understanding GCHandle.Alloc with GCHandleType.Weak means we don't need to free the handle, right?

iOS for parent destructor

maybe iOS mono implementation has different GC timing for that certain situation?

In my understanding GCHandle.Alloc with GCHandleType.Weak means we don't need to free the handle, right? > iOS for parent destructor maybe iOS mono implementation has different GC timing for that certain situation?
rmarinho commented 2017-02-10 14:26:34 -08:00 (Migrated from github.com)
Copy Link

@splhack i m not a expert but from internal feedback i got that "Yea, you still need to dispose of the GCHandle manually. "

@splhack i m not a expert but from internal feedback i got that _"Yea, you still need to dispose of the GCHandle manually. "_
👍 1
rmarinho commented 2017-02-10 14:31:10 -08:00 (Migrated from github.com)
Copy Link

About the test , maybe something around this :

9a68a14699

About the test , maybe something around this : https://github.com/rmarinho/yoga/commit/9a68a14699a038043d4176e5d5ce8b7c965e2b3a
splhack commented 2017-02-10 14:33:32 -08:00 (Migrated from github.com)
Copy Link

Or just skip GC test on iOS?

Or just skip GC test on iOS?
rmarinho commented 2017-02-10 14:39:36 -08:00 (Migrated from github.com)
Copy Link

sure that's an option ..

sure that's an option ..
splhack commented 2017-02-10 14:55:48 -08:00 (Migrated from github.com)
Copy Link

How about this attempt to call GCHandle.Free?

How about this attempt to call GCHandle.Free?
rmarinho commented 2017-02-10 14:57:31 -08:00 (Migrated from github.com)
Copy Link

👍

👍
rmarinho commented 2017-02-15 16:38:49 -08:00 (Migrated from github.com)
Copy Link

Can we merge this? why is the build failing ?

Can we merge this? why is the build failing ?
splhack commented 2017-02-15 16:56:45 -08:00 (Migrated from github.com)
Copy Link

Yeah, we're trying to do that with #386.

Yeah, we're trying to do that with #386.
facebook-github-bot commented 2017-02-15 19:10:38 -08:00 (Migrated from github.com)
Copy Link

@splhack has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@splhack has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D4570778).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#388
No description provided.
Delete Branch "aot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?