Simplify/Dedup STEP 5 Line 2271 - 2367 #395

New Issue

2017-02-13T03:08:23-08:00

woehrl01 commented

2017-02-13 03:08:23 -08:00

(Migrated from github.com)

The code here contains lots of dublicate code, which could be greatly reduced. It switches only if its row or column. The code would be much more readable/maintainable if we calculate all of this named with cross/main-axis and only switch at the end to set either childWidth or childHeight.

If you agree, I'd put up a PR for this.

The code [here](https://github.com/facebook/yoga/blob/master/yoga/Yoga.c#L2271-2367) contains lots of dublicate code, which could be greatly reduced. It switches only if its row or column. The code would be much more readable/maintainable if we calculate all of this named with cross/main-axis and only switch at the end to set either ```childWidth``` or ```childHeight```. If you agree, I'd put up a PR for this.

woehrl01 commented

2017-02-14 15:23:41 -08:00

(Migrated from github.com)

create PR

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#395