DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Buck build broken for c# #404

New Issue
Closed
opened 2017-02-15 14:33:52 -08:00 by rmarinho · 7 comments
rmarinho commented 2017-02-15 14:33:52 -08:00 (Migrated from github.com)
Copy Link

Report

Issues and Steps to Reproduce

Clone repo and run buck build of csharp targets or build-native.sh

Expected Behavior

Should run fine

Actual Behavior

Fails

Link to Code

If you have some code that maintainers can clone/test for themselves, bugs can be resolved much faster. Please paste a link here.

When applicable, use this fiddle to post a web repro.

# Report - [x] I have searched [existing issues](https://github.com/facebook/yoga/issues) and this is not a duplicate # Issues and Steps to Reproduce Clone repo and run buck build of csharp targets or build-native.sh # Expected Behavior Should run fine # Actual Behavior Fails # Link to Code ***If you have some code that maintainers can clone/test for themselves, bugs can be resolved much faster. Please paste a link here.*** ***When applicable, use this [fiddle](https://jsfiddle.net/emilsjolander/jckmwztt/) to post a web repro.***
splhack commented 2017-02-15 15:54:20 -08:00 (Migrated from github.com)
Copy Link

I'm working on it.

I'm working on it.
rmarinho commented 2017-02-15 16:39:33 -08:00 (Migrated from github.com)
Copy Link

I had to revert 3 commits that touched .buckconfig and buck file .

I had to revert 3 commits that touched .buckconfig and buck file .
rmarinho commented 2017-02-15 17:15:25 -08:00 (Migrated from github.com)
Copy Link

I think is still failing for Android? you need to check the changes of a580712b2f on .buckconfig

I think is still failing for Android? you need to check the changes of a580712b2f6833070ed4323b54a26805332eb43d on .buckconfig
splhack commented 2017-02-15 17:27:35 -08:00 (Migrated from github.com)
Copy Link

which target? buck build //csharp:yoganet#android-armv7,shared is fine for me.

which target? `buck build //csharp:yoganet#android-armv7,shared` is fine for me.
rmarinho commented 2017-02-15 17:34:13 -08:00 (Migrated from github.com)
Copy Link
iRuiXam-MBP:csharp rmarinho$ buck build //csharp:yoganet#android-x86,shared
Not using buckd because watchman isn't installed.
[-] PROCESSING BUCK FILES...FINISHED 0.0s [100%] 🐳  New buck daemon
[+] DOWNLOADING... (0.00 B/S, TOTAL: 0.00 B, 0 Artifacts)
[+] BUILDING...0.8s
BUILD FAILED: Unrecognized flavor in target //csharp:yoganet#android-x86,shared while parsing //csharp/BUCK
Here are some things you can try to get the following flavors to work::
android-x86 : Make sure you have the Android SDK/NDK installed and set up. See https://buckbuild.com/setup/install.html#locate-android-sdk
``` iRuiXam-MBP:csharp rmarinho$ buck build //csharp:yoganet#android-x86,shared Not using buckd because watchman isn't installed. [-] PROCESSING BUCK FILES...FINISHED 0.0s [100%] 🐳 New buck daemon [+] DOWNLOADING... (0.00 B/S, TOTAL: 0.00 B, 0 Artifacts) [+] BUILDING...0.8s BUILD FAILED: Unrecognized flavor in target //csharp:yoganet#android-x86,shared while parsing //csharp/BUCK Here are some things you can try to get the following flavors to work:: android-x86 : Make sure you have the Android SDK/NDK installed and set up. See https://buckbuild.com/setup/install.html#locate-android-sdk ```
rmarinho commented 2017-02-15 17:34:35 -08:00 (Migrated from github.com)
Copy Link

if i revert that commit it works.

if i revert that commit it works.
splhack commented 2017-02-15 17:41:00 -08:00 (Migrated from github.com)
Copy Link

hmm, I can't repro that. Do you have .buckconfig.local?

$ git rev-parse HEAD
2199a7908d49f4e1e81c32acf4407bbf9e4952ad
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit, working directory clean

$ rm -rf buck-out
$ buck build //csharp:yoganet#android-x86,shared
[-] PROCESSING BUCK FILES...FINISHED 0.1s [100%]
[-] DOWNLOADING... (0.00 B/S AVG, TOTAL: 0.00 B, 0 Artifacts)
[-] BUILDING...FINISHED 5.6s [100%] (10/10 JOBS, 10 UPDATED, 5 [50.0%] CACHE MISS)
hmm, I can't repro that. Do you have `.buckconfig.local`? $ git rev-parse HEAD 2199a7908d49f4e1e81c32acf4407bbf9e4952ad $ git status On branch master Your branch is up-to-date with 'origin/master'. nothing to commit, working directory clean $ rm -rf buck-out $ buck build //csharp:yoganet#android-x86,shared [-] PROCESSING BUCK FILES...FINISHED 0.1s [100%] [-] DOWNLOADING... (0.00 B/S AVG, TOTAL: 0.00 B, 0 Artifacts) [-] BUILDING...FINISHED 5.6s [100%] (10/10 JOBS, 10 UPDATED, 5 [50.0%] CACHE MISS)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#404
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?