Improvement/add test runner #42

2015-02-04T18:57:43-08:00

daviskoh commented

2015-02-04 18:57:43 -08:00

(Migrated from github.com)

Don't know if this is imposing, but I thought testing may be easier if there was a more manageable way to run them. Also, the added benefit is that when ready to test this in other browsers, karma launchers for them can be added to the package.json & karma.conf.js. What do you think?

daviskoh commented

2015-02-04 19:07:18 -08:00

(Migrated from github.com)

also, the specs in Layout-random-test.js seem to be failing:

is this a known issue?

also, the specs in Layout-random-test.js seem to be failing: ![fail](https://cloud.githubusercontent.com/assets/5395403/6054360/1265509a-acba-11e4-8d21-b27374e11831.png) ![fail2](https://cloud.githubusercontent.com/assets/5395403/6054367/27fdb672-acba-11e4-9b58-f4d0ff46cf15.png) is this a known issue?

vjeux commented

2015-02-04 19:10:00 -08:00

(Migrated from github.com)

Nice, thanks for doing that :) Never used karma, this looks sweet. For the failing tests, there's a few behaviors which I believe are bugs in Chrome.

https://github.com/facebook/css-layout/blob/master/src/tests/Layout-test.js#L1117-L1119
https://github.com/facebook/css-layout/blob/master/src/tests/Layout-test.js#L1176-L1178

And, there's a few edge cases that are not properly supported yet unfortunately :(

Nice, thanks for doing that :) Never used karma, this looks sweet. For the failing tests, there's a few behaviors which I believe are bugs in Chrome. https://github.com/facebook/css-layout/blob/master/src/__tests__/Layout-test.js#L1117-L1119 https://github.com/facebook/css-layout/blob/master/src/__tests__/Layout-test.js#L1176-L1178 And, there's a few edge cases that are not properly supported yet unfortunately :(

daviskoh commented

2015-02-04 19:25:11 -08:00

(Migrated from github.com)

Ah I see...well np anyways. Glad to help.

Question: what do you think about adding a linter (like jshint) to the npm pretest script so that the JS files get linted before tests get executed?

Also, good job on Reactjs Conf, the presentation on native looked super cool!

Ah I see...well np anyways. Glad to help. Question: what do you think about adding a linter (like jshint) to the npm pretest script so that the JS files get linted before tests get executed? Also, good job on Reactjs Conf, the presentation on native looked super cool!

vjeux commented

2015-02-04 20:06:53 -08:00

(Migrated from github.com)

Happy to take it in, however i'm doing a lot of hacks that are probably not eslint friendly :p

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#42