DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Improvement/add linter #44

Merged
daviskoh merged 12 commits from improvement/add-linter into master 2015-02-20 09:44:20 -08:00
Conversation 4 Commits 12 Files Changed 14 +313 -274
daviskoh commented 2015-02-05 17:06:53 -08:00 (Migrated from github.com)
Copy Link

Changed:

  • added eslint & .eslintrc (tried to unbiased judgements on proj style)
  • all specs pass & everything seems to build
  • reverted back karma runner to only run desired specs

Feedback is much appreciated!

Changed: - added eslint & .eslintrc (tried to unbiased judgements on proj style) - all specs pass & everything seems to build - reverted back karma runner to only run desired specs Feedback is much appreciated!
daviskoh commented 2015-02-05 17:37:50 -08:00 (Migrated from github.com)
Copy Link

Ill switch it over eslint!

Ill switch it over eslint!
daviskoh commented 2015-02-17 18:34:48 -08:00 (Migrated from github.com)
Copy Link

This was quite a messy change adding eslint and addressing the errors so I will fully understand if you decide to reject it T.T. The main comment has been updated.

This was quite a messy change adding eslint and addressing the errors so I will fully understand if you decide to reject it T.T. The main comment has been updated.
vjeux commented 2015-02-17 18:53:16 -08:00 (Migrated from github.com)
Copy Link

I'm in vacation until the end of the week. Will check when I get back home, sorry for the wait :(

I'm in vacation until the end of the week. Will check when I get back home, sorry for the wait :(
vjeux commented 2015-02-20 09:44:16 -08:00 (Migrated from github.com)
Copy Link

So good, lots of great stuff here :) Thanks for doing this!

So good, lots of great stuff here :) Thanks for doing this!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#44
No description provided.
Delete Branch "improvement/add-linter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?