Rework javascript api to match README #50

2015-02-15T18:02:28-08:00

jimmyhmiller commented

2015-02-15 18:02:28 -08:00

(Migrated from github.com)

This is a fix for https://github.com/facebook/css-layout/issues/24

It doesn't require any changes to the transpiled code, but exposes a nice api for javascript. I did have to create a new file as the main for package.json. I'd love to work on simplifying the structure of the javascript in the future. Perhaps moving the layout algorithm into its own file. But those sorts of changes can be done later.

Let me know if you have any changes you'd like me to make.

This is a fix for https://github.com/facebook/css-layout/issues/24 It doesn't require any changes to the transpiled code, but exposes a nice api for javascript. I did have to create a new file as the main for package.json. I'd love to work on simplifying the structure of the javascript in the future. Perhaps moving the layout algorithm into its own file. But those sorts of changes can be done later. Let me know if you have any changes you'd like me to make.

vjeux commented

2015-02-15 18:07:56 -08:00

(Migrated from github.com)

So good, thanks for doing that. Please keep the pull requests coming for improving the js api :)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#50