DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fractial leftover #508

Closed
arcanis wants to merge 3 commits from fractial-leftover into master
pull from: fractial-leftover
merge into: DaddyFrosty:master
Conversation 3 Commits 3 Files Changed 9 +1026 -68
arcanis commented 2017-04-13 15:13:35 -07:00 (Migrated from github.com)
Copy Link

This PR fixes #490

  • Coordinates are now rounded depending on their position on the world pixel grid instead of the local grid, which means that they are now properly rounded relatively to their parents.

  • Because this change is an improvement over the Chrome implementation which suffer from the same bug that we do, I've implemented new expect-* attributes for html fixtures. They can be used to override the generated assertion that we must match, and also validate that Chrome's behaviour is the one we expect. You can see them in action here.

This PR fixes #490 - Coordinates are now rounded depending on their position on the world pixel grid instead of the local grid, which means that they are now properly rounded relatively to their parents. - Because this change is an improvement over the Chrome implementation which suffer from the same bug that we do, I've implemented new `expect-*` attributes for html fixtures. They can be used to override the generated assertion that we must match, and also validate that Chrome's behaviour is the one we expect. You can see them in action [here](https://github.com/facebook/yoga/pull/508/files#diff-054aae1dfb4ca4e6f76130952274dcdaR66).
arcanis commented 2017-04-13 15:43:05 -07:00 (Migrated from github.com)
Copy Link

It should also fix the JS Travis build: apparently the emscripten sdk file structure changed in a recent release.

It should also fix the JS Travis build: apparently the emscripten sdk file structure changed in a recent release.
woehrl01 commented 2017-04-13 23:04:09 -07:00 (Migrated from github.com)
Copy Link

I like the idea of expected could be useful for some flex-basis tests where chrome returns some invalid values, top. 👍

I like the idea of ```expected``` could be useful for some ```flex-basis``` tests where chrome returns some invalid values, top. 👍
arcanis commented 2017-04-26 14:53:11 -07:00 (Migrated from github.com)
Copy Link

I'm going to close this PR, since its related issue has been fixed in aa5b296 :)

I'm going to close this PR, since its related issue has been fixed in aa5b296 :)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#508
No description provided.
Delete Branch "fractial-leftover"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?