DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Make Java measure thread-safe. #60

Merged
tcmulcahy merged 1 commits from thread-safe-measure into master 2015-03-27 10:01:33 -07:00
Conversation 3 Commits 1 Files Changed 9 +72 -36
tcmulcahy commented 2015-03-23 10:58:21 -07:00 (Migrated from github.com)
Copy Link

The measure method in java previously referenced a global MEASURE_OUTPUT variable. This means that css layout could not be done safely from multiple threads. The naive solution would be to create a MeasureOutput on each measure invocation, but since Android is sensitive to allocation and garbage collection, we instead force a MeasureOutput instance to be passed in to calculateLayout. Since it would be strange and non-intuitive to pass MeasureOutput to calculateLayout, this implementation detail is hidden from clients by wrapping the MeasureOutput in a CSSLayoutContext object. Clients are free to re-use the same CSSLayoutContext object, provided that they ensure it is not used concurrently from multiple threads.

The measure method in java previously referenced a global MEASURE_OUTPUT variable. This means that css layout could not be done safely from multiple threads. The naive solution would be to create a MeasureOutput on each measure invocation, but since Android is sensitive to allocation and garbage collection, we instead force a MeasureOutput instance to be passed in to calculateLayout. Since it would be strange and non-intuitive to pass MeasureOutput to calculateLayout, this implementation detail is hidden from clients by wrapping the MeasureOutput in a CSSLayoutContext object. Clients are free to re-use the same CSSLayoutContext object, provided that they ensure it is not used concurrently from multiple threads.
vjeux commented 2015-03-23 11:05:42 -07:00 (Migrated from github.com)
Copy Link

@kmagiera or @astreet can you review this?

@kmagiera or @astreet can you review this?
kmagiera commented 2015-03-25 17:58:24 -07:00 (Migrated from github.com)
Copy Link

Thanks! Looks good, please just add a class level comment to CSSLayoutContext that will explain the purpose of this class and that a separate instance should be used when calculateLayout is called concurrently for different node hierarchies.

Thanks! Looks good, please just add a class level comment to CSSLayoutContext that will explain the purpose of this class and that a separate instance should be used when calculateLayout is called concurrently for different node hierarchies.
tcmulcahy commented 2015-03-26 15:32:40 -07:00 (Migrated from github.com)
Copy Link

Okay, I've added the javadoc, and also fixed a long line.

Okay, I've added the javadoc, and also fixed a long line.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#60
No description provided.
Delete Branch "thread-safe-measure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?